Feat: fetch newsletter subscribers#694
Closed
Scepter00 wants to merge 4 commits intohngprojects:devfrom
Closed
Conversation
Am0du
reviewed
Mar 1, 2025
| private final EmailServiceImpl emailService; | ||
|
|
||
| private static final int DEFAULT_PAGE = 0; | ||
| private static final int DEFAULT_SIZE = 20; |
Contributor
There was a problem hiding this comment.
remove this and add to your controller class:
@RequestParam(defaultValue = "0") int page,
@RequestParam(defaultValue = "10") int size,
|
|
||
| public SubscribersResponse getSubscribersResponse(Integer page, Integer size) { | ||
| int effectivePage = (page == null || page < 0) ? DEFAULT_PAGE : page; | ||
| int effectiveSize = (size == null || size <= 0) ? DEFAULT_SIZE : size; |
Contributor
There was a problem hiding this comment.
Not needed once you implement the change above
…nd set them in NewsletterController and also updated tests to reflect these changes
…nd set them in NewsletterController and also updated tests to reflect these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API endpoint allows authorized users (e.g., administrators) to retrieve a complete list of subscribers who have signed up for the newsletter. The response will include relevant subscriber details such as email and subscription date, enabling efficient management and communication. A GET request available at
GET/api/v1/newsletter-subscription.Changes implemented