fix: Refactored uploadProfileImage method exceptions#701
Merged
Am0du merged 2 commits intohngprojects:devfrom Mar 2, 2025
Merged
fix: Refactored uploadProfileImage method exceptions#701Am0du merged 2 commits intohngprojects:devfrom
Am0du merged 2 commits intohngprojects:devfrom
Conversation
nevisadhiambo
changed the title
nevisadhiambo
changed the title
nevisadhiambo
changed the title
Am0du
approved these changes
Mar 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Exception Handling
BadRequestExceptionfor missing files and invalid file typesProfilePictureUploadExceptioninstead of returning aResponseEntityinside the catch block.Benefits
✅ Cleaner and more readable code.
✅ Improved maintainability by separating concerns.
✅ Follows the required standards