Skip to content

updated the send 2fa function, to not check for 2fa before sending#179

Open
wulzymart wants to merge 1 commit into
mainfrom
feat/update_send2fa
Open

updated the send 2fa function, to not check for 2fa before sending#179
wulzymart wants to merge 1 commit into
mainfrom
feat/update_send2fa

Conversation

@wulzymart
Copy link
Copy Markdown
Collaborator

This is an update to send2fa function

Description

This change was made

//CODE COMMENTED OUT BECAUSE 2FA MUST BE SENT BEFORE IT IS ENABLED
      // if (user.twoFactorAuth === false) {
      //   throw new Forbidden('2fa is not enabled');
      // }
```

this change was done because it disrupts the frontend flow of enabling 2fa which requires that a code be sent first before it is enabled
​
## Related Issue (Link to linear ticket)
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->
​
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
​
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
​
## Screenshots (if appropriate - Postman, etc):
​
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
​
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant