Skip to content

adds ZREVRANGEBYSCORE to client along with tests #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexanderscott wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds ZREVRANGEBYSCORE to client along with tests #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,15 @@ func (client *Client) Zrangebyscore(key string, start float64, end float64) ([][
return res.([][]byte), nil
}

func (client *Client) Zrevrangebyscore(key string, end float64, start float64) ([][]byte, error) {
res, err := client.sendCommand("ZREVRANGEBYSCORE", key, strconv.FormatFloat(end, 'f', -1, 64), strconv.FormatFloat(start, 'f', -1, 64))
if err != nil {
return nil, err
}

return res.([][]byte), nil
}

func (client *Client) Zcount(key string, min float64, max float64) (int, error) {
res, err := client.sendCommand("ZCOUNT", key, strconv.FormatFloat(min, 'f', -1, 64), strconv.FormatFloat(max, 'f', -1, 64))
if err != nil {
Expand Down
15 changes: 15 additions & 0 deletions redis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,14 @@ func verifyHash(t *testing.T, key string, expected map[string][]byte) {

func TestSortedSet(t *testing.T) {
svals := []string{"a", "b", "c", "d", "e"}
svalsInverse := []string{"e", "d", "c", "b", "a"}
ranks := []float64{0.0, 1.0, 2.0, 3.0, 4.0}
vals := make([][]byte, len(svals))
valsInverse := make([][]byte, len(svalsInverse))

for i := 0; i < len(svals); i++ {
vals[i] = []byte(svals[i])
valsInverse[i] = []byte(svalsInverse[i])
_, err := client.Zadd("zs", vals[i], ranks[i])
if err != nil {
t.Fatal("zdd failed" + err.Error())
Expand All @@ -546,13 +550,24 @@ func TestSortedSet(t *testing.T) {
if !reflect.DeepEqual(data, vals[0:i+1]) {
t.Fatal("zrange failed")
}

revData, _ := client.Zrevrange("zs", 0, i)
if !reflect.DeepEqual(revData, valsInverse[0:i+1]) {
t.Fatal("zrevrange failed")
}
}

for i := 0; i <= 4; i++ {
data, _ := client.Zrangebyscore("zs", 0, float64(i))
if !reflect.DeepEqual(data, vals[0:i+1]) {
t.Fatal("zrangebyscore failed")
}
revData, _ := client.Zrevrangebyscore("zs", float64(i), 0)
if !reflect.DeepEqual(revData, valsInverse[4-i:5]) {
t.Fatal("zrevrangebyscore failed")
}
}

//incremement
for i := 0; i <= 4; i++ {
client.Zincrby("zs", vals[i], 1)
Expand Down