Skip to content

Distinguish between small and big integers #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamed-barakat
Copy link
Member

This PR is a rebased resurrection of #1633 that I had to close since I cannot push into Fabian's branches:

@zickgraf wrote in #1633 (comment):

This is a tentative attempt to distinguish between small and big integers in GAP to mirror the situation in Julia. Doing this across the whole codebase seems like an enormous effort. I'm not sure if this effort is worth it.

@mohamed-barakat If you are interested in this, we can look at some examples (e.g. the CategoryOfRows) in more detail and check what would have to be done.

@mohamed-barakat
Copy link
Member Author

mohamed-barakat commented Jul 2, 2025

@mohamed-barakat replied in #1633 (comment):

This is a tentative attempt to distinguish between small and big integers in GAP to mirror the situation in Julia. Doing this across the whole codebase seems like an enormous effort. I'm not sure if this effort is worth it.

@mohamed-barakat If you are interested in this, we can look at some examples (e.g. the CategoryOfRows) in more detail and check what would have to be done.

Yes, I am interested. I would also like to have a version of SkeletalFinSets which uses the small integers and not the gmp-integers.

@mohamed-barakat
Copy link
Member Author

@zickgraf replied in #1633 (comment):

Yes, I am interested. I would also like to have a version of SkeletalFinSets which uses the small integers and not the gmp-integers.

What application do you have in mind? This category would not have products etc. anymore, correct?

@mohamed-barakat
Copy link
Member Author

@zickgraf replied in #1633 (comment):

There are also some subtleties in Julia when working with ranges of big ints:

julia> typeof(length(BigInt(1):BigInt(1)))
BigInt

julia> typeof(length(map(x -> x,BigInt(1):BigInt(1))))
Int64

@mohamed-barakat mohamed-barakat marked this pull request as draft July 2, 2025 20:33
@mohamed-barakat
Copy link
Member Author

@kamalsaleh: Could this be interesting for what you are currently working on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants