-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support aria2 in download widget #2226
base: dev
Are you sure you want to change the base?
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
ae40bfc
to
64b6214
Compare
64b6214
to
fea3ba4
Compare
aria2: { | ||
name: "Aria2", | ||
secretKinds: [["apiKey"]], | ||
iconUrl: "https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons@master/png/aria2.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me Package size exceeded the configured limit of 50 MB. Try https://github.com/homarr-labs/dashboard-icons/tree/master/png/aria2.png instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the icon does not exist and has to be added to the dashboard-icons repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: "Aria2", | ||
secretKinds: [["apiKey"]], | ||
iconUrl: "https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons@master/png/aria2.png", | ||
category: ["downloadClient", "torrent", "http(s)"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike that the category has brackets in it's name. Just a suggestion: multiProtocolDownloadClient
?
@Meierschlumpf / @SeDemal WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Aria2's main page: "It supports HTTP/HTTPS, FTP, SFTP, BitTorrent and Metalink"
Since it supports more than http(s), and this client is the only one using all the different kinds, I suggest to just call it "miscellaneous" or something like that. All in all though, it actually boils down to the type of exchange which is one way or both ways, so http is of the same type as usenet downloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to use "miscellaneous"
packages/integrations/src/download-client/aria2/aria2-client.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-client.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-client.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-integration.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-integration.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-integration.ts
Outdated
Show resolved
Hide resolved
packages/integrations/src/download-client/aria2/aria2-integration.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an empty file?
I'll need to spend some more time later on for a proper review.
|
@SeDemal @manuel-rw @Meierschlumpf finished. can you help review again ? is there existing way to disable the action button base on download item state ? |
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)Change Logs:
upspeed
,sent
andratio
to torrent's item only.DownloadClientStatus
interface to support the multiple download type client such aria2.Limitations:
downloading
andleeching
.completed
entries can only be removed.