Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): add responsive layout system #2271

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Feb 7, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Pending Todos

  • Test mysql migration with some sample data
  • Test imports from oldmarr
  • Issues with hooks (see screenshot below)
  • Add remove button for board layouts (at least one has to exist)
  • Add layouts when creating board (two options, one for sm, md, lg and one for base layout)
  • Fix unit tests for board router
  • Add unit tests for save-layouts
  • Rename section / item layouts

image

Closes #2269

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Feb 7, 2025
@Meierschlumpf Meierschlumpf self-assigned this Feb 7, 2025
@Meierschlumpf Meierschlumpf changed the title Add layouts feat: add responsive board layout system Feb 7, 2025
@Meierschlumpf Meierschlumpf changed the title feat: add responsive board layout system feat(boards): add responsive layout system Feb 7, 2025
Copy link

deepsource-io bot commented Feb 7, 2025

Here's the code health analysis summary for commits f6a5c04..c2db9bc. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 10 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.89% 8989 / 41058
🔵 Statements 21.89% 8989 / 41058
🔵 Functions 26.92% 357 / 1326
🔵 Branches 63.66% 1011 / 1588
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/boards/_types.ts 0% 0% 0% 0% 1-16
apps/nextjs/src/app/[locale]/boards/[name]/settings/_layout.tsx 0% 0% 0% 0% 1-97
apps/nextjs/src/components/board/items/item-actions.tsx 0% 0% 0% 0% 1-114
apps/nextjs/src/components/board/items/item-content.tsx 0% 0% 0% 0% 1-118
apps/nextjs/src/components/board/items/item-menu.tsx 0% 0% 0% 0% 1-126
apps/nextjs/src/components/board/items/actions/create-item.ts 93.18% 70% 100% 93.18% 55, 58-59
apps/nextjs/src/components/board/items/actions/duplicate-item.ts 65.67% 66.66% 100% 65.67% 44-63, 81-88
apps/nextjs/src/components/board/items/actions/empty-position.ts 100% 100% 100% 100%
apps/nextjs/src/components/board/items/actions/move-and-resize-item.ts 95.83% 85.71% 100% 95.83% 27
apps/nextjs/src/components/board/items/actions/move-item-to-section.ts 95.83% 85.71% 100% 95.83% 28
apps/nextjs/src/components/board/items/actions/remove-item.ts 100% 100% 100% 100%
apps/nextjs/src/components/board/items/actions/section-elements.ts 100% 100% 100% 100%
apps/nextjs/src/components/board/items/actions/test/shared.ts 100% 100% 100% 100%
apps/nextjs/src/components/board/sections/content.tsx 0% 0% 0% 0% 1-85
apps/nextjs/src/components/board/sections/dynamic-section.tsx 0% 0% 0% 0% 1-36
apps/nextjs/src/components/board/sections/empty-section.tsx 0% 0% 0% 0% 1-25
apps/nextjs/src/components/board/sections/section-actions.tsx 0% 0% 0% 0% 1-86
apps/nextjs/src/components/board/sections/section-context.ts 0% 0% 0% 0% 1-23
apps/nextjs/src/components/board/sections/use-section-items.ts 0% 0% 0% 0% 1-53
apps/nextjs/src/components/board/sections/category/category-actions.ts 0% 0% 0% 0% 1-144
apps/nextjs/src/components/board/sections/category/actions/remove-category.ts 88.97% 82% 100% 88.97% 16-17, 30-31, 80-88, 134, 149
apps/nextjs/src/components/board/sections/dynamic/dynamic-actions.ts 0% 0% 0% 0% 1-27
apps/nextjs/src/components/board/sections/dynamic/dynamic-menu.tsx 0% 0% 0% 0% 1-45
apps/nextjs/src/components/board/sections/dynamic/actions/add-dynamic-section.ts 0% 0% 0% 0% 1-51
apps/nextjs/src/components/board/sections/dynamic/actions/remove-dynamic-section.ts 0% 100% 100% 0% 7-62
apps/nextjs/src/components/board/sections/gridstack/gridstack.tsx 0% 0% 0% 0% 1-36
apps/nextjs/src/components/board/sections/gridstack/use-gridstack.ts 0% 0% 0% 0% 1-372
packages/api/src/middlewares/integration.ts 13.55% 100% 66.66% 13.55% 32-75, 94-136, 149-174
packages/api/src/router/board.ts 22.82% 92.85% 29.41% 22.82% 44-52, 55-62, 137-206, 215-230, 261-472, 491-495, 508-510, 513-515, 518-538, 541-544, 547-669, 676-702, 705-1113, 1164, 1183, 1194-1209, 1214-1215, 1237-1252, 1257-1258, 1277-1279, 1293-1304, 1327-1405, 1408-1441, 1444-1535, 1546-1552, 1555-1561, 1564, 1567, 1570
packages/api/src/router/app/app-access-control.ts 12.12% 100% 0% 12.12% 10-11, 14-18, 21-45
packages/api/src/router/board/grid-algorithm.ts 93.33% 90% 100% 93.33% 37-41, 152-153
packages/api/src/router/widgets/notebook.ts 46.42% 100% 100% 46.42% 20-36
packages/auth/permissions/integration-query-permissions.ts 97.53% 94.87% 100% 97.53% 52-53
packages/boards/src/context.tsx 16.66% 100% 0% 16.66% 17-54, 57-64, 67-70, 74-81, 84, 87-90
packages/db/schema/index.ts 100% 0% 100% 100%
packages/db/schema/mysql.ts 100% 100% 66.66% 100%
packages/db/schema/sqlite.ts 100% 100% 67.56% 100%
packages/modals-collection/src/boards/import-board-modal.tsx 0% 0% 0% 0% 1-153
packages/old-import/src/import-error.ts 50% 100% 0% 50% 5-8, 13-14
packages/old-import/src/move-widgets-and-apps-merge.ts 2.27% 100% 0% 2.27% 11-130, 133-206, 209-279, 282-302, 309-333
packages/old-import/src/settings.ts 38.63% 100% 0% 38.63% 27-56
packages/old-import/src/components/initial-oldmarr-import.tsx 0% 0% 0% 0% 1-94
packages/old-import/src/components/initial/board-selection-card.tsx 0% 0% 0% 0% 1-76
packages/old-import/src/import/input.ts 81.81% 100% 100% 81.81% 13-14
packages/old-import/src/import/collections/board-collection.ts 2.53% 100% 0% 2.53% 18-110
packages/old-import/src/mappers/map-board.ts 11.76% 100% 0% 11.76% 11-25
packages/old-import/src/mappers/map-breakpoint.ts 9.09% 100% 0% 9.09% 9-18
packages/old-import/src/mappers/map-column-count.ts 8.33% 100% 0% 8.33% 4-14
packages/old-import/src/mappers/map-item.ts 3.26% 100% 0% 3.26% 15-61, 64-116
packages/old-import/src/prepare/prepare-boards.ts 33.33% 100% 0% 33.33% 5-6
packages/old-import/src/prepare/prepare-items.ts 18.18% 100% 0% 18.18% 6-15
packages/old-import/src/prepare/prepare-single.ts 25% 100% 0% 25% 7-13
packages/old-schema/src/index.ts 100% 100% 100% 100%
packages/old-schema/src/tile.ts 84.21% 100% 50% 84.21% 63-71
packages/validation/src/board.ts 100% 50% 100% 100%
packages/validation/src/index.ts 100% 100% 100% 100%
packages/validation/src/shared.ts 100% 100% 100% 100%
Generated in workflow #4998 for commit c2db9bc by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: introduce responsive layout system
1 participant