Skip to content

Improve types #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve types #28

wants to merge 6 commits into from

Conversation

@alexrudd2
Copy link

@alexrudd2 alexrudd2 commented Mar 31, 2025

These are meant to be uncontroverisal type improvements. I'm splitting out more significant changes into another PR.

puddly
puddly reviewed Mar 31, 2025
View reviewed changes
@alexrudd2
Copy link
Author

alexrudd2 commented Apr 1, 2025

I've reverted the BaseException / Exception one, as well as the failing test.

For some numbers,

pyright goes from 52 errors to 23. mypy from 24 to 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puddly puddly puddly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexrudd2 @puddly