Remove Thread credential sync from start of Matter commissioning flow (…

…#4150)

- After discussion with Thread dev, remove Thread credential syncing from the start of the Matter commissioning flow. There are 2 major reasons for this:
   * it significantly slows down the flow while only being useful some of the time
   * the results have limited usefulness because the API limits how much Home Assistant can influence the device data
  The alternative for the user is to use the manual 'import credentials' button in the frontend (matching iOS), or access the sync option in the app settings > troubleshooting menu.

app/src/full/java/io/homeassistant/companion/android/matter/MatterCommissioningViewModel.kt

@@ -2,7 +2,6 @@ package io.homeassistant.companion.android.matter
 
 import android.app.Application
 import android.content.IntentSender
-import android.util.Log
 import androidx.activity.result.ActivityResult
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -91,24 +90,12 @@ class MatterCommissioningViewModel @Inject constructor(
         }
     }
 
-    suspend fun syncThreadIfNecessary(): IntentSender? {
+    fun syncThreadIfNecessary(): IntentSender? {
         step = CommissioningFlowStep.Working
-        return try {
-            val result = threadManager.syncPreferredDataset(
-                getApplication<Application>().applicationContext,
-                serverId,
-                false,
-                viewModelScope
-            )
-            when (result) {
-                is ThreadManager.SyncResult.OnlyOnDevice -> result.exportIntent
-                is ThreadManager.SyncResult.AllHaveCredentials -> result.exportIntent
-                else -> null
-            }
-        } catch (e: Exception) {
-            Log.w(TAG, "Unable to sync preferred Thread dataset, continuing", e)
-            null
-        }
+        // The app used to sync Thread credentials here until commit 26a472a, but it was
+        // (temporarily?) removed due to slowing down the Matter commissioning flow for the user
+        // and limited usefulness of the result (because of API limitations)
+        return null
     }
 
     fun onThreadPermissionResult(result: ActivityResult, code: String) {

app/src/main/java/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt

@@ -345,24 +345,11 @@ class WebViewPresenterImpl @Inject constructor(
         if (_matterThreadStep.value != MatterThreadStep.REQUESTED) {
             _matterThreadStep.tryEmit(MatterThreadStep.REQUESTED)
 
-            mainScope.launch {
-                val deviceThreadIntent = try {
-                    when (val result = threadUseCase.syncPreferredDataset(context, serverId, false, CoroutineScope(coroutineContext + SupervisorJob()))) {
-                        is ThreadManager.SyncResult.OnlyOnDevice -> result.exportIntent
-                        is ThreadManager.SyncResult.AllHaveCredentials -> result.exportIntent
-                        else -> null
-                    }
-                } catch (e: Exception) {
-                    Log.w(TAG, "Unable to sync preferred Thread dataset, continuing", e)
-                    null
-                }
-                if (deviceThreadIntent != null) {
-                    matterThreadIntentSender = deviceThreadIntent
-                    _matterThreadStep.tryEmit(MatterThreadStep.THREAD_EXPORT_TO_SERVER_MATTER)
-                } else {
-                    startMatterCommissioningFlow(context)
-                }
-            }
+            // The app used to sync Thread credentials here until commit 26a472a, but it was
+            // (temporarily?) removed due to slowing down the Matter commissioning flow for the user
+            // and limited usefulness of the result (because of API limitations)
+
+            startMatterCommissioningFlow(context)
         } // else already waiting for a result, don't send another request
     }