Forecast.io: Added minutely, hourly, and daily summary

[aceat64]

Description:
Additional summary types, shown on Forecast.io as "next hour", "next 24 hours" and "next 7 days".

Related issue (if applicable): #

Example entry for configuration.yaml (if applicable):

sensor:
  platform: forecast
  api_key: YOUR_APP_KEY
  monitored_conditions:
    - minutely_summary
    - hourly_summary
    - daily_summary

Checklist:

If code communicates with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[fabaff]

pylint issue: R:191, 0: Too many instance attributes (9/7) (too-many-instance-attributes)

Otherwise work and looks ok for me.

[aceat64]

I'm not sure how to fix that, I'm still pretty new to python. My guess is I need to put everything in self.data instead of adding "self.data_minutely", "self.data_hourly", and "self.data_daily".

[fabaff]

You could add # pylint: disable=... before the part which causes the error. If there are reasons to do.

Perhaps it's worth to think to only work with self.data = forecast and access/split the information (currently, minutely,hourly,daily) in the update part.

Can you remove the unused import? Seems to be a left-over from the past.

[aceat64]

I think that import needs to be there, otherwise I get the following:

E:185,15: Undefined variable 'forecastio' (undefined-variable)

[fabaff]

Sorry, my bad...the import is needed for catching the exception.

[balloob]

We shouldn't fetch this data unless we need it.

[balloob]

Or does it work just like currently and does it not cause an extra request to the server ?

[aceat64]

According to the python-forecastio docs when we call forecastio.load_forecast() we get all the data, so it shouldn't be any extra requests.

[balloob]

Looks good! 🐬