Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Jul 7, 2022

Proposed change

⚠️ Work in progress / early testing

Blocking upstream issues/PRs/things:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Jul 7, 2022
@frenck frenck self-assigned this Jul 7, 2022
@frenck frenck mentioned this pull request Jul 7, 2022
23 tasks
epenet
epenet previously approved these changes Jul 7, 2022
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@epenet epenet self-requested a review July 7, 2022 20:54
@frenck frenck marked this pull request as ready for review July 7, 2022 20:59
@frenck frenck dismissed epenet’s stale review July 7, 2022 20:59

Remove by request (wrong button)

@frenck frenck marked this pull request as draft July 7, 2022 20:59
@frenck frenck mentioned this pull request Jul 12, 2022
23 tasks
@frenck frenck force-pushed the frenck-2022-1360 branch from eb4a346 to c3532d0 Compare August 4, 2022 20:52
@frenck
Copy link
Member Author

frenck commented Aug 17, 2022

Temporary closing this PR, as we await aiohttp...
There is no path forward at this point.

@frenck frenck closed this Aug 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
@frenck frenck reopened this Sep 21, 2022
@frenck frenck changed the title Add Python 3.11 beta to CI Add Python 3.11 RC to CI Sep 21, 2022
@frenck
Copy link
Member Author

frenck commented Sep 21, 2022

Almost there!

Failed to build grpcio guppy3 ha-av uamqp cchardet

Closing PR until there is more news...

@frenck frenck closed this Sep 21, 2022
@frenck frenck reopened this Sep 26, 2022
@frenck frenck closed this Sep 28, 2022
@cdce8p cdce8p added the ci-keep-cache Keep raw pip cache for PRs (not necessary "usually") label Nov 16, 2022
@frenck frenck deleted the frenck-2022-1360 branch January 3, 2023 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci-keep-cache Keep raw pip cache for PRs (not necessary "usually") cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants