Add page to explain the roles in developing #2802

joostlek · 2025-09-23T21:29:20Z

Proposed change

Add page to explain the roles in developing

Type of change

Document existing features within Home Assistant
Document new or changing features for which there is an existing pull request elsewhere
Spelling or grammatical corrections, or rewording for improved clarity
Changes to the backend of this documentation
Remove stale or deprecated documentation

Checklist

I have read and followed the documentation guidelines.
I have verified that my changes render correctly in the documentation.

Additional information

This PR fixes or closes issue: fixes #
Link to relevant existing code or pull request:

joostlek · 2025-09-23T21:29:38Z

docs/development_roles.md

+## Integration owners
+
+Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.


Probably also mention the relevant ADR

Why mention how it was formerly known and as first sentence ? Is it important to know?

Integration owners don't need to be code owners

Not agreeing on the last comment @balloob. How would that work? Someone just shouts; " I own this things?".

There needs to be some for of tracking here.

joostlek · 2025-09-23T21:30:16Z

docs/development_roles.md

+Comments and concerns raised by integration owners are held in high regard, as they possess in-depth knowledge of the integration they oversee.
+Integration owners are mentioned in every pull request that changes the code of their integration, and in every issue that is opened for their integration.


I kinda want to emphasize that integration owners don't have a final say in what they approve or create for their integration. That still lies with the members.

(suggestions welcome btw)

The word "mentioned" is github jargon. Use word notified.

Also. Platinum integrations require code owners approval so there definitely is something to say. I think this text downplays their role, making it less appealing to become one!

joostlek · 2025-09-23T21:30:28Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.
+The core team generally meets every week to discuss pull requests and architectural proposals.


Should we add the members of the core team?

I think that aligns with our working in the open, but I also tend to leave it up to our colleagues if they want to be that out in the open. Would linking to the org member list work in this case, or are Members included there?

Link to the team in GitHub instead.

joostlek · 2025-09-23T21:30:50Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.
+The core team generally meets every week to discuss pull requests and architectural proposals.


Should we add the moment of meeting?

Not really needed; just mention of a weekend cadence should be good enough

joostlek · 2025-09-23T21:31:24Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.
+The core team generally meets every week to discuss pull requests and architectural proposals.


Should we add that if people have strong concerns, that they can ask for a PR to be discussed here?

I think that's fair to do. You mean strong concerns against a change, right, not just this update?

Yes, when someone thinks they are in an impasse because they think something is reasonable and they have proper arguments (or examples where something similar happened) that would warrant a discussion

This is what architecture discussion or for.

balloob · 2025-09-23T22:44:14Z

docs/development_roles.md

+
+## Core members
+
+Core members are contributors with write access to the Home Assistant Core repository.


Suggested change

Core members are contributors with write access to the Home Assistant Core repository.

Core members, identified by the "member" label, are contributors with write access to the Home Assistant Core repository.

But I would add another sentence. They are members of the core team maintaining Home Assistant.

balloob · 2025-09-23T22:45:38Z

docs/development_roles.md

+## Integration owners
+
+Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.


Why mention how it was formerly known and as first sentence ? Is it important to know?

balloob · 2025-09-23T22:46:14Z

docs/development_roles.md

+## Integration owners
+
+Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.


Integration owners don't need to be code owners

balloob · 2025-09-23T22:48:09Z

docs/development_roles.md

+Comments and concerns raised by integration owners are held in high regard, as they possess in-depth knowledge of the integration they oversee.
+Integration owners are mentioned in every pull request that changes the code of their integration, and in every issue that is opened for their integration.


The word "mentioned" is github jargon. Use word notified.

Also. Platinum integrations require code owners approval so there definitely is something to say. I think this text downplays their role, making it less appealing to become one!

frenck

I think we should move this page out of core and talk about the broader scope.

For example, in frontend, apps or any other scope of development there are roles too.

frenck · 2025-09-24T04:47:09Z

docs/development_roles.md

+Comments and concerns raised by integration owners are held in high regard, as they possess in-depth knowledge of the integration they oversee.
+Integration owners are mentioned in every pull request that changes the code of their integration, and in every issue that is opened for their integration.
+
+## Core team


We need to change the higher level names and clearly distinguish the OHF part in the role names.

The HA GitHub org is currently already reflecting that.

That said; I do want to change the naming fully for this one, and consider forming sn architectural group of some sort.

frenck · 2025-09-24T04:48:06Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.
+The core team generally meets every week to discuss pull requests and architectural proposals.


Link to the team in GitHub instead.

frenck · 2025-09-24T04:48:59Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.
+The core team generally meets every week to discuss pull requests and architectural proposals.


This is what architecture discussion or for.

frenck · 2025-09-24T04:50:39Z

docs/development_roles.md

+## Integration owners
+
+Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.


Not agreeing on the last comment @balloob. How would that work? Someone just shouts; " I own this things?".

There needs to be some for of tracking here.

abmantis · 2025-09-24T09:49:01Z

docs/development_roles.md

+
+## Integration owners
+
+Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.


integration owners are core members

Integration owners are not "Core members"

abmantis · 2025-09-24T09:49:12Z

docs/development_roles.md

+## Core team
+
+The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
+They are employed by The Open Home Foundation.


Suggested change

They are employed by The Open Home Foundation.

They are employed by the Open Home Foundation.

Add page to explain the roles in developing

e56e957

joostlek commented Sep 23, 2025

View reviewed changes

balloob reviewed Sep 23, 2025

View reviewed changes

frenck reviewed Sep 24, 2025

View reviewed changes

abmantis reviewed Sep 24, 2025

View reviewed changes

Add page to explain the roles in developing

1f6139c

		## Integration owners

		Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.

		Comments and concerns raised by integration owners are held in high regard, as they possess in-depth knowledge of the integration they oversee.
		Integration owners are mentioned in every pull request that changes the code of their integration, and in every issue that is opened for their integration.


		## Core members

		Core members are contributors with write access to the Home Assistant Core repository.

	Core members are contributors with write access to the Home Assistant Core repository.
	Core members, identified by the "member" label, are contributors with write access to the Home Assistant Core repository.

	They are employed by The Open Home Foundation.
	They are employed by the Open Home Foundation.

Uh oh!

Add page to explain the roles in developing #2802

Are you sure you want to change the base?

Add page to explain the roles in developing #2802

Uh oh!

Conversation

joostlek commented Sep 23, 2025

Proposed change

Type of change

Checklist

Additional information

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants