-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Group react deps together, they fail if not in sync #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughModified Dependabot configuration to add a new "react" update group for npm packages (react and react-dom) and removed the separate "github-actions" ecosystem update block. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
1-20: Incomplete PR description.The PR description is empty—no proposed changes or rationale are documented. While the code change itself is clear from the title and diff, a completed description would help reviewers understand the intent and any edge cases (for example, whether other react-related packages like @types/react or @types/react-dom should also be grouped).
Please fill in the PR description template with details such as the reason for this change, any testing performed, and verification that the dependabot configuration parses correctly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.github/dependabot.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
.github/dependabot.yml (1)
13-16: Approve the react group configuration.The new "react" group correctly pairs react and react-dom packages to keep their versions in sync during dependency updates. The formatting and indentation are consistent with the existing docusaurus group, and the patterns are appropriate for npm packages.
However, I notice a discrepancy: the AI summary indicates that the github-actions ecosystem block should have been removed, but lines 17–20 show it still present. Please confirm whether the github-actions block was intentionally kept or should be removed as part of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @silamon 👍
../Frenck
Proposed change
See #2819
Type of change
Checklist
Additional information
Summary by CodeRabbit
Note: This release contains no user-facing changes. Updates are internal infrastructure improvements.