Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuki.markdown #38151

Closed
wants to merge 4 commits into from
Closed

Conversation

AJediIAm
Copy link
Contributor

@AJediIAm AJediIAm commented Mar 23, 2025

Add extra suggestions for direct integration.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Enhanced Nuki integration docs to clarify control options via Nuki Bridge and WiFi-enabled Smart Locks.
    • Updated prerequisites for connecting devices to WiFi and enabling developer mode.
    • Renamed the MQTT section to "Local integration alternatives" and expanded its content.
    • Added new sections on HomeKit support and Matter support for enhanced compatibility.

Add extra suggestions for direct integration.
@AJediIAm AJediIAm requested review from pvizeli and pree as code owners March 23, 2025 12:14
@home-assistant home-assistant bot added the current This PR goes into the current branch label Mar 23, 2025
Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 4b8b937
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67e7d224cd1bac0008eb730e
😎 Deploy Preview https://deploy-preview-38151--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 23, 2025

📝 Walkthrough

Walkthrough

The Nuki integration documentation has been updated to enhance the description of controlling Nuki Smart Locks. It now specifies that control can be achieved via both a Nuki Bridge and WiFi-enabled Smart Locks, with an emphasis on cloud connectivity. A new section on local integration alternatives has been introduced, along with sections detailing HomeKit and Matter support. The prerequisites for connecting devices to WiFi and enabling developer mode have been clarified, and the MQTT support section has been updated to include relevant devices.

Changes

File Change Summary
source/_integrations/nuki.markdown - Updated: Control description to include both Nuki Bridge and WiFi-enabled Smart Locks with cloud connectivity
- Updated: Prerequisites for connecting to WiFi and enabling developer mode
- Renamed: "MQTT support" to "Local integration alternatives"
- Added: "Homekit support" section
- Added: "Matter Support" section
- Updated: MQTT support details to include Nuki Smart Lock 3.0 Pro and 4th generation devices

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
source/_integrations/nuki.markdown (1)

82-83: Remove Trailing Whitespace in Matter Support Section

Static analysis detected trailing whitespace on line 83. Please remove any extraneous trailing spaces to adhere to our markdown linting guidelines.

-Smart Lock Ultra, Smart Lock Pro, Smart Lock Go, Smart Locks of 4th Generation support Matter over Thread and can directly integrate with Home Assistant.␣
+Smart Lock Ultra, Smart Lock Pro, Smart Lock Go, Smart Locks of 4th Generation support Matter over Thread and can directly integrate with Home Assistant.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

83-83: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7957c79 and ff3cc2c.

📒 Files selected for processing (1)
  • source/_integrations/nuki.markdown (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/nuki.markdown

83-83: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🪛 GitHub Actions: home-assistant.io Test
source/_integrations/nuki.markdown

[error] 74-74: Incorrect usage of the term: “Homekit”, use “HomeKit” instead terminology


## Matter Support

Smart Lock Ultra, Smart Lock Pro, Smart Lock Go, Smart Locks of 4th Generation support Matter over Thread and can directly integrate with Home Assistant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of sprinkling this document with all kind of references to different ways of integrating; I'd suggest to make a single paragraph that explains it all for all of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it.
Let me try to figure out how to do this in GitHub.
Apologies if I hit the wrong button somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates. I hope it shows up correctly...

@home-assistant home-assistant bot marked this pull request as draft March 25, 2025 08:05
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@AJediIAm AJediIAm marked this pull request as ready for review March 29, 2025 09:54
@home-assistant home-assistant bot requested a review from frenck March 29, 2025 09:54
- Group alternative integrations
- Add references to smart locks with build in wifi
- Add links to Nuki knowledge articles and HA integrations
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
source/_integrations/nuki.markdown (1)

79-81: 🛠️ Refactor suggestion

Fix HomeKit Section Heading and Markdown Link Syntax

  • The heading on line 79 currently reads “### Homekit support”. It must be updated to “### HomeKit support” to adhere to our documentation standards.
  • On line 81, the link for the HomeKit integration is incorrectly formatted by using parentheses instead of markdown link brackets. Please update it to the standard markdown syntax.
-### Homekit support
+### HomeKit support
-The 2nd and 3rd Generation Smart Locks support [HomeKit via Bluetooth](https://help.nuki.io/hc/en-001/articles/19948907390737-Apple-HomeKit-via-Bluetooth) and can directly integrate with Home Assistant through the (HomeKit integration)(/integrations/homekit_controller/#adding-a-homekit-device-through-bluetooth).
+The 2nd and 3rd Generation Smart Locks support [HomeKit via Bluetooth](https://help.nuki.io/hc/en-001/articles/19948907390737-Apple-HomeKit-via-Bluetooth) and can directly integrate with Home Assistant through the [HomeKit integration](/integrations/homekit_controller/#adding-a-homekit-device-through-bluetooth).
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test

[error] 79-79: Incorrect usage of the term: “Homekit”, use “HomeKit” instead terminology

🧹 Nitpick comments (5)
source/_integrations/nuki.markdown (5)

22-23: Correct Link Text and Remove Trailing Spaces

In the introduction, the link text “[Buildin WiFi]” should be corrected to “[Built-in WiFi]” for clarity and consistency with the linked resource. Also, please remove the extra trailing spaces on these lines to satisfy markdown linting guidelines.

-The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge) or Nuki Smart Lock with [Buildin WiFi](https://help.nuki.io/hc/en-001/sections/4402761196817-Built-in-Wi-Fi) using the cloud. 
+The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge) or Nuki Smart Lock with [Built-in WiFi](https://help.nuki.io/hc/en-001/sections/4402761196817-Built-in-Wi-Fi) using the cloud.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


23-23: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


27-27: Improve Grammar in Prerequisites Section

The sentence “Turn on the HTTP API and check the details in the screen.” would read more naturally as “check the details on the screen.” Additionally, consider capitalizing “wifi” to “WiFi” for consistency with other parts of the document.

-... Turn on the HTTP API and check the details in the screen.
+... Turn on the HTTP API and check the details on the screen.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~27-~27: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...n on the HTTP API and check the details in the screen. Please note that the API to...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)


[typographical] ~27-~27: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...lease note that the API token should be 6-20 characters long, even though the app al...

(HYPHEN_TO_EN)


75-77: Local Integration Alternatives Heading and Trailing Space Cleanup

The new heading “## Local integration alternatives” is clear. However, the paragraph on line 77 has a trailing space that should be removed per markdown lint recommendations.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

77-77: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


83-86: Correct MQTT Link Formatting

In the MQTT support section on line 85, the markdown link for MQTT is incorrectly wrapped with an additional pair of square brackets. Please update it to use the standard [link text](url) format.

-[MQTT]([https://support.nuki.io/hc/en-us/articles/12947926779409-MQTT-support])
+[MQTT](https://support.nuki.io/hc/en-us/articles/12947926779409-MQTT-support)

88-90: Address Trailing Space in Matter Support Section

The “### Matter Support” heading on line 88 has an extra trailing space. Although the content on line 90 is clear, please remove any unnecessary trailing whitespace to comply with markdown standards.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

88-88: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff3cc2c and 4b8b937.

📒 Files selected for processing (1)
  • source/_integrations/nuki.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nuki.markdown

[uncategorized] ~27-~27: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...n on the HTTP API and check the details in the screen. Please note that the API to...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)


[typographical] ~27-~27: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...lease note that the API token should be 6-20 characters long, even though the app al...

(HYPHEN_TO_EN)

🪛 markdownlint-cli2 (0.17.2)
source/_integrations/nuki.markdown

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


23-23: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


77-77: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


88-88: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🪛 GitHub Actions: home-assistant.io Test
source/_integrations/nuki.markdown

[error] 79-79: Incorrect usage of the term: “Homekit”, use “HomeKit” instead terminology

@AJediIAm AJediIAm closed this Mar 30, 2025
@AJediIAm AJediIAm deleted the patch-6 branch March 30, 2025 11:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants