-
Notifications
You must be signed in to change notification settings - Fork 746
Remove deprecated fields and options from Supervisor API #6226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It seems the |
4471241 to
7031a58
Compare
|
@agners good catch. I kept that field and removed the other two. Ironically that was the one field that wasn't even in the documentation let alone the python client. Once we refactor the hassio integration to fully leverage the client library then we'll return and remove that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
|
Actually, I asked Claude Code to check bashio, and it raised issues: I guess we should first drop these fields from bashio 🤔 |
|
@agners added a cli PR to remove support for I'm not really sure what claude is talking about with the third one. I think its referring to how we populate the autocomplete for addons here: But that doesn't use the deprecated |
Claude is talking about |
|
@agners ok I see what you're saying now. Unfortunately its not as simple as removing a few things though, looks like the bashio library is pretty out of date. It still isn't aware of the |
|
@agners ok put up the PR for bashio: hassio-addons/bashio#176 |
Proposed change
Remove deprecated fields from
/supervisor/infoAPI and deprecated options from/supervisor/optionsas all have been deprecated for more then 2 years and are not in the client library.Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: