Skip to content

Commit

Permalink
run improved linter on non-typescript files
Browse files Browse the repository at this point in the history
  • Loading branch information
bwp91 committed Aug 25, 2024
1 parent 00705fb commit ef81e9c
Show file tree
Hide file tree
Showing 39 changed files with 264 additions and 243 deletions.
18 changes: 11 additions & 7 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,19 @@ assignees: ''
<!-- You must use the issue template below when submitting a bug -->

**Describe The Bug:**

<!-- A clear and concise description of what the bug is. -->

**To Reproduce:**

<!-- Steps to reproduce the behavior. -->

**Expected behavior:**

<!-- A clear and concise description of what you expected to happen. -->

**Logs:**

<!-- Bug reports that do not contain logs may be closed without warning. -->

```
Expand All @@ -32,16 +36,16 @@ Show your homebridge config.json here
```

**Screenshots:**

<!-- If applicable, add screenshots to help explain your problem. -->

**Environment:**

* **Node.js Version**: <!-- node -v -->
* **NPM Version**: <!-- npm -v -->
* **Homebridge Version**: <!-- homebridge -V -->
* **Homebridge UI Version**:
* **Operating System**: Raspbian / Ubuntu / Debian / Windows / macOS / Docker
* **Process Supervisor**: Docker / Systemd / init.d / pm2 / launchctl / hb-service / other / none

- **Node.js Version**: <!-- node -v -->
- **NPM Version**: <!-- npm -v -->
- **Homebridge Version**: <!-- homebridge -V -->
- **Homebridge UI Version**:
- **Operating System**: Raspbian / Ubuntu / Debian / Windows / macOS / Docker
- **Process Supervisor**: Docker / Systemd / init.d / pm2 / launchctl / hb-service / other / none

<!-- Click the "Preview" tab before you submit to ensure the formatting is correct. -->
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
name: Bug Report
description: Create a report to help us improve
labels: ["bug"]
labels: [bug]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
Before we start, be sure you are aware of the following points:
* If your issue is specific to a certain plugin, create the issue on that plugin's GitHub project page instead.
* Avoid duplicating any existing issues which already track or resolve your problem, search the existing issues first.
* Aim to find a descriptive and precise title for your bug report.
Expand All @@ -18,7 +18,7 @@ body:
label: Describe The Bug
description: |
Pleased provide a clear and concise description of what the bug is. Be sure to include:
* What is happening?
* What you expect to happen?
* Clear steps explaining how to reproduce the problem.
Expand All @@ -43,8 +43,8 @@ body:
label: Config
render: JSON
description: |
If relevant to your bug report, please include your Homebridge config (`config.json`).
If relevant to your bug report, please include your Homebridge config (`config.json`).
* If you're unsure if the config is relevant, please include it.
* Be sure to **remove any sensitive information (passwords, tokens, etc.).**
validations:
Expand Down
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Feature Request
description: Suggest an idea for this project
labels: ["enhancement"]
labels: [enhancement]
body:
- type: markdown
attributes:
Expand All @@ -12,12 +12,11 @@ body:
label: Feature Description
description: |
Please provide an overview of the what feature you'd like to see.
* What is happening?
* What you expect to happen?
* What problems would this new feature solve?
placeholder: |
Tip: You can attach images or files by clicking this area to highlight it and then dragging files in.
validations:
required: true

10 changes: 5 additions & 5 deletions .github/ISSUE_TEMPLATE/support-request.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: Support Request
description: Need help?
labels: ["question"]
labels: [question]
body:
- type: markdown
attributes:
value: |
Please read the following before you start filling out this form:
* If your issue is specific to a certain plugin, create the issue on that plugin's GitHub project page instead.
* Support via GitHub issues is limited. You may find it more beneficial ask questions on the [Homebridge Discord](https://discord.gg/kqNCe2D) or [Reddit](https://www.reddit.com/r/homebridge/) communities instead.
* Search through existing issues (resolved or open) which might provide a solution to your problem already.
Expand All @@ -17,7 +17,7 @@ body:
label: Current Situation
description: |
Please provide an overview of the current situation and illustrate potential problems or shortcomings.
* What is happening?
* What you expect to happen?
* Clear steps explaining how to reproduce the problem.
Expand All @@ -42,8 +42,8 @@ body:
label: Config
render: JSON
description: |
If relevant to your support, please include your Homebridge config (`config.json`).
If relevant to your support, please include your Homebridge config (`config.json`).
* If you're unsure if the config is relevant, please include it.
* Be sure to **remove any sensitive information (passwords, tokens, etc.).**
validations:
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/wiki-change-request.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: Wiki Change Request
description: want change?
labels: ["wiki change request"]
labels: [wiki change request]
body:
- type: markdown
attributes:
value: |
Please read the following before you start filling out this form:
* This form is for requesting changes to the Homebridge Organization wiki pages only.
- type: textarea
id: proposed-change
Expand All @@ -28,6 +28,6 @@ body:
description: |
Please provide a link to the wiki page you would like to see changed.
If you are requesting a new page, please provide details of where you would like to see this page linked from.
If you are requesting a new page, please provide details of where you would like to see this page linked from.
validations:
required: true
14 changes: 7 additions & 7 deletions .github/SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
This document outlines security procedures and general policies for the
`homebridge-config-ui-x` project.

* [Reporting a Bug](#reporting-a-bug)
* [Disclosure Policy](#disclosure-policy)
* [Comments on this Policy](#comments-on-this-policy)
- [Reporting a Bug](#reporting-a-bug)
- [Disclosure Policy](#disclosure-policy)
- [Comments on this Policy](#comments-on-this-policy)

## Reporting a Bug

Expand All @@ -31,10 +31,10 @@ When the security team receives a security bug report, they will assign it to a
primary handler. This person will coordinate the fix and release process,
involving the following steps:

* Confirm the problem and determine the affected versions.
* Audit code to find any potential similar problems.
* Prepare fixes for all releases still under maintenance. These fixes will be
released as fast as possible to npm.
- Confirm the problem and determine the affected versions.
- Audit code to find any potential similar problems.
- Prepare fixes for all releases still under maintenance. These fixes will be
released as fast as possible to npm.

## Comments on this Policy

Expand Down
6 changes: 3 additions & 3 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Add 'beta' label to any PR where the base branch name starts with `beta` or has a `beta` section in the name
beta:
- base-branch: ['^beta', 'beta', 'beta*']
- base-branch: [^beta, beta, 'beta*']

# Add 'beta' label to any PR where the base branch name starts with `beta` or has a `beta` section in the name
alpha:
- base-branch: ['^alpha', 'alpha', 'alpha*']
- base-branch: [^alpha, alpha, 'alpha*']

# Add 'latest' label to any PR where the base branch name starts with `latest` or has a `latest` section in the name
latest:
- base-branch: ['^latest', 'latest', 'latest*']
- base-branch: [^latest, latest, 'latest*']
32 changes: 16 additions & 16 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
name-template: 'v$RESOLVED_VERSION'
tag-template: 'v$RESOLVED_VERSION'
name-template: v$RESOLVED_VERSION
tag-template: v$RESOLVED_VERSION

categories:
- title: 'Breaking Changes'
- title: Breaking Changes
labels:
- 'breaking change'
- title: 'Featured Changes'
- breaking change
- title: Featured Changes
labels:
- 'feature'
- 'enhancement'
- title: 'Bug Fixes'
- feature
- enhancement
- title: Bug Fixes
labels:
- 'fix'
- 'bugfix'
- 'bug'
- title: 'Other Changes'
- fix
- bugfix
- bug
- title: Other Changes
labels:
- 'documentation'
- documentation

autolabeler:
- label: 'fix'
- label: fix
branch:
- '/fix\/.+/'
title:
- '/fix/i'
- label: 'feature'
- /fix/i
- label: feature
branch:
- '/feature\/.+/'

Expand Down
18 changes: 9 additions & 9 deletions .github/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ changelog:
categories:
- title: Breaking Changes 🛠
labels:
- 'breaking change'
- breaking change
- title: Featured Changes ✨
labels:
- 'feature'
- 'enhancement'
- feature
- enhancement
- title: Bug Fixes 🐛
labels:
- 'fix'
- 'bugfix'
- 'bug'
- fix
- bugfix
- bug
- title: Other Changes
labels:
- "chore"
- "housekeeping"
- "*"
- chore
- housekeeping
- '*'
25 changes: 12 additions & 13 deletions .github/workflows/alpha-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ on:
jobs:
publish:
if: ${{ github.repository == 'homebridge/homebridge-config-ui-x' }}
name: "Publish Pre Release Alpha to NPM"
name: Publish Pre Release Alpha to NPM
uses: homebridge/.github/.github/workflows/npm-publish.yml@latest
with:
tag: 'alpha'
tag: alpha
dynamically_adjust_version: true
npm_version_command: 'pre'
pre_id: 'alpha'
npm_version_command: pre
pre_id: alpha
install_cmd: npm ci && cd ui && npm ci
secrets:
npm_auth_token: ${{ secrets.npm_token }}

pre-release-alpha:
needs: [publish]
name: "Create New Github Alpha Pre Release"
name: Create New Github Alpha Pre Release
if: ${{ github.repository == 'homebridge/homebridge-config-ui-x' }}
runs-on: ubuntu-latest
steps:
Expand All @@ -40,7 +40,7 @@ jobs:
[How To Test Upcoming Changes](https://github.com/homebridge/homebridge-config-ui-x/wiki/How-To-Test-Upcoming-Changes)
keep_num: 5
keep_tags: false

attach-artifact:
name: Attach Artifact
needs: [publish, pre-release-alpha]
Expand Down Expand Up @@ -72,19 +72,18 @@ jobs:
echo "Bundle is under 10MB, stopping"
exit 1
fi
- name: Upload tar.gz Bundle to GitHub Artifacts v${{ needs.publish.outputs.NPM_VERSION }}
uses: actions/upload-artifact@v4
with:
name: 'homebridge-config-ui-x-${{ needs.publish.outputs.NPM_VERSION }}.tar.gz'
path: |
./homebridge-config-ui-x-${{ needs.publish.outputs.NPM_VERSION }}.tar.gz

- name: Upload SHASUMS256.txt to GitHub Artifacts v${{ needs.publish.outputs.NPM_VERSION }}
uses: actions/upload-artifact@v4
with:
name: 'SHASUMS256.txt'
name: SHASUMS256.txt
path: |
./SHASUMS256.txt
Expand All @@ -97,12 +96,12 @@ jobs:

github-releases-to-discord:
name: Discord Webhooks
needs: [publish,pre-release-alpha,attach-artifact]
needs: [publish, pre-release-alpha, attach-artifact]
uses: homebridge/.github/.github/workflows/discord-webhooks.yml@latest
with:
title: "Homebridge UI Alpha Release"
title: Homebridge UI Alpha Release
description: |
Version `v${{ needs.publish.outputs.NPM_VERSION }}`
url: "https://github.com/homebridge/homebridge-config-ui-x/releases/tag/v${{ needs.publish.outputs.NPM_VERSION }}"
url: 'https://github.com/homebridge/homebridge-config-ui-x/releases/tag/v${{ needs.publish.outputs.NPM_VERSION }}'
secrets:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK_URL_BETA }}
Loading

0 comments on commit ef81e9c

Please sign in to comment.