Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router/trie-router): fix label with trailing wildcard pattern #3892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

usualoma
Copy link
Member

@usualoma usualoma commented Feb 4, 2025

TrieRouter was not able to obtain parameters in the pattern of the added test, so I fixed it.

https://github.com/honojs/hono/compare/main...usualoma:fix/label-trailing-wildcard?expand=1#diff-18f50c43f41503d5cc65c9d783b57e0c683eb26957f59a11edb2d099f40114c2R502

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@usualoma
Copy link
Member Author

usualoma commented Feb 4, 2025

@yusukebe
Would you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant