-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added details of new community folks. #252
Conversation
Hey Jules, the pictures must be added here: Could you send a PR for https://github.com/hoodiehq/hoodie-css with the pictures? If not we can do that for you of course. Great work 👍 |
No no, I can do it :) I just didn't know where to add them! Thanks :D |
I’ve merged your PR for the images. We should scale them down and crop them so that they load faster, but we can do that later. For this PR, you got Nick’s last name wrong (It's Hehr, not Herr), and you still need to add the image URLs. I fixed the name of Nick’s image in the hoodie-css repo already :) Here is the diff for the changes you still need to do before we can merge :) Let us know if you have any questions diff --git a/community/index.html b/community/index.html
index d5d0838..d310df8 100644
--- a/community/index.html
+++ b/community/index.html
@@ -121,8 +121,8 @@ title: hood.ie community
<div class="cb person-bio">
<article>
<figure class="grid-3 l">
- <img class="bio-img sw" src="" width="152" height="152" alt="Portrait photo(black and white) of Christoph Witzko." />
- <img class="bio-img bunt" src="" width="152" height="152" alt="Portrait photo(colour) of Christoph Witzko." />
+ <img class="bio-img sw" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/default-sw/christoph-witzko.jpg" width="152" height="152" alt="Portrait photo(black and white) of Christoph Witzko." />
+ <img class="bio-img bunt" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/hover-bunt/christoph-witzko--hover.jpg" width="152" height="152" alt="Portrait photo(colour) of Christoph Witzko." />
</figure>
<span class="h6">Backend Developer & Operations Engineer</span>
<h1 class="h3">
@@ -352,12 +326,12 @@ title: hood.ie community
<div class="cb person-bio">
<article>
<figure class="grid-3 l">
- <img class="bio-img sw" src=" " width="152" height="152" alt="Portrait photo(black and white) of Nick Herr." />
- <img class="bio-img bunt" src=" " width="152" height="152" alt="Portrait photo(colour) of Nick Herr." />
+ <img class="bio-img sw" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/default-sw/nick-hehr.jpg" width="152" height="152" alt="Portrait photo(black and white) of Nick Hehr." />
+ <img class="bio-img bunt" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/hover-bunt/nick-hehr--hover.jpg" width="152" height="152" alt="Portrait photo(colour) of Nick Hehr." />
</figure>
<span class="h6">Frontend Developer & Hoodie Maintainer</span>
<h1 class="h3">
- <a name="nick-herr" class="jump-mark">Nick Herr</a>
+ <a name="nick-hehr" class="jump-mark">Nick Hehr</a>
</h1>
<p>
An empathetic community member, avid Disney parks & animation fan, and bouldering nut. His mustache is a figment of your imagination.
@@ -390,8 +364,8 @@ title: hood.ie community
<div class="cb person-bio">
<article>
<figure class="grid-3 l">
- <img class="bio-img sw" src="" width="152" height="152" alt="Portrait photo(black and white) of Patricia Garcia." />
- <img class="bio-img bunt" src="" width="152" height="152" alt="Portrait photo(colour) of Patricia Garcia." />
+ <img class="bio-img sw" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/default-sw/patricia-garcia.jpg" width="152" height="152" alt="Portrait photo(black and white) of Patricia Garcia." />
+ <img class="bio-img bunt" src="http://hoodiehq.github.io/hoodie-css/src/content_img/community/hover-bunt/patricia-garcia--hover.jpg" width="152" height="152" alt="Portrait photo(colour) of Patricia Garcia." />
</figure>
<span class="h6">Frontend & Backend Developer</span>
<h1 class="h3">
|
Hey Gregor, I think that’s all done now :)
|
Verified the copy changes, LGTM |
regarding size, all other images are 150x150px |
I believe the images being the same was done by whoever added me when I first became a core member. |
Love my bio. Thanks for adding me to the list! 😄 |
</p> | ||
</article> | ||
<aside class="bio-link"> | ||
<a href="https://github.com/hipsterbrown" target="_blank">GitHub</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add my Twitter as well.
<a href="https://twitter.com/hipsterbrown" target="_blank">Twitter</a>
merged via 9ebaf61. Thanks so much for your help & patience with us @jo-porter |
Fixes hoodiehq/editorial#68
Issue #239, contributors addedto community page and photos for each attached below.
Patricia B&W







Patricia colour
Jen B&W
Jen colour
Nick B&W
Nick colour
Christoph colour
Christoph B&W