-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screw holes #267
base: master
Are you sure you want to change the base?
Screw holes #267
Conversation
Just M3 and M4, for now. More (both metric and imperial) to come.
Plus other miscellaneous adjustments to the screw hole symbol, etc.
Accidentally deleted the part's JSON file prior to previous commit.
1. Removed parameter program (unnecessarily complicated). Replaced "keep-out" parametric polygon on assembly layer with manually drawn line circle. 2. Added matching line circles on top and bottom silkscreen layers. 3. Fixed reference and value designators (to make rules checks happy). 4. Added reference dimensions for mechanical hole and keep-out circle.
1. Set flags, suitable for non-electrical parts. 2. Edited description.
Bot! please |
This comment has been minimized.
This comment has been minimized.
Bot! check my work |
This comment has been minimized.
This comment has been minimized.
Not sure how I managed to double up on the courtyard polygons. Do we care about the "Unit has no pins!" flag? |
Bot! |
This comment has been minimized.
This comment has been minimized.
LGTM apart from the naming. Why not name it "Screw hole, M3"? Putting "hole" in the tags should make it easier to find. |
On Mon, Feb 07, 2022 at 02:29:08PM -0800, Lukas K. wrote:
Why not name it "Screw hole, M3"? Putting "hole" in the tags should
make it easier to find.
Works for me. I'll get started on the remaining parts. I plan on
creating M3-M8, and #0-#10, plus 1/4" and 5/16".
|
Also cleaned up names, tags on existing screw hole packages.
Bot! find my mistakes |
Matching parts would be useful. sigh Please stand by... |
This comment has been minimized.
This comment has been minimized.
Bot! for reals this time |
This comment has been minimized.
This comment has been minimized.
Some had version set to 1. Unreleased parts should have version 0.
Bot! |
This comment has been minimized.
This comment has been minimized.
Bot! tell me I'm done |
This comment has been minimized.
This comment has been minimized.
This reverts commit d321000.
Bot! |
This review is brought to you by the Horizon EDA Poolbot commit eb40288. Items in this PR
Non-items
Parts overview (excluding derived)Bold items are from this PR
DetailsPartsscrew hole, #10✔️ Checks passed
Flags
screw hole, #4✔️ Checks passed
Flags
screw hole, #3✔️ Checks passed
Flags
screw hole, 5/16"✔️ Checks passed
Flags
screw hole, #2✔️ Checks passed
Flags
screw hole, M5✔️ Checks passed
Flags
screw hole, M6✔️ Checks passed
Flags
screw hole, M3✔️ Checks passed
Flags
screw hole, #0✔️ Checks passed
Flags
screw hole, #8✔️ Checks passed
Flags
screw hole, #1✔️ Checks passed
Flags
screw hole, M2✔️ Checks passed
Flags
screw hole, M2.5✔️ Checks passed
Flags
screw hole, 1/4"✔️ Checks passed
Flags
screw hole, #6✔️ Checks passed
Flags
screw hole, M8✔️ Checks passed
Flags
screw hole, #5✔️ Checks passed
Flags
screw hole, M4✔️ Checks passed
Flags
Entitiesscrew hole✔️ Checks passed
Unitsscrew hole✔️ Checks passed
❌ Unit has no pins! Symbol: screw hole✔️ Checks passed
Packagesscrew hole, M2.5
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M2
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M3
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M4
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M5
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M6
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, M8
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #0
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #1
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #10
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #2
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #3
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #4
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #5
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #6
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS #8
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS 5/16"
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
screw hole, UTS 1/4"
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
|
shouldn't be in this PR |
Three example screw hole parts, for review. Ref. issue #266.