Skip to content

Update support for DJI air 3 drones #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2025
Merged

Update support for DJI air 3 drones #413

merged 3 commits into from
Jun 21, 2025

Conversation

Pradip-p
Copy link
Collaborator

@Pradip-p Pradip-p commented Dec 24, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related issue

Fixes #537

Describe this PR

  • updated support for DJI air 3 drones

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

  • πŸ“– Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
  • πŸ‘·β€β™€οΈ Create small PRs. In most cases, this will be possible.
  • βœ… Provide tests for your changes.
  • πŸ“ Use descriptive commit messages.
  • πŸ“— Update any related documentation and include any relevant screenshots.

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added enhancement New feature or request backend Related to backend code labels Dec 24, 2024
@Pradip-p Pradip-p changed the title Update support for DJJ air 3 drones Update support for DJI air 3 drones Dec 24, 2024
@Pradip-p Pradip-p self-assigned this Dec 25, 2024
@spwoodcock
Copy link
Member

spwoodcock commented Apr 16, 2025

Please see related discussion here: hotosm/drone-flightplan#28
And continue discussion here if needed πŸ™

Key question to answer / look into here: hotosm/drone-flightplan#28 (comment)

@Bin-ze wrote:
I think forward_photo_height and side_photo_width can be calculated using a more concise formula,According to the principle of similar triangles:

forward_photo_height / AGL = Image_height / Image_focal
so:
forward_photo_height = AGL * (Image_height / Image_focal)

(Image_height / Image_focal) is fixed Parameters in same drone type.

Regarding GSD_to_AGL_CONST, the calculation method you mentioned is the same as mine, so I have no doubts.

My question is just why forward_photo_height can be calculated relatively accurately, but an approximation is used.

@github-actions github-actions bot added the dependency:drone-flightplan Requires updates in drone-flightplan label Apr 16, 2025
@spwoodcock spwoodcock requested a review from nrjadkry April 16, 2025 14:34
@spwoodcock spwoodcock marked this pull request as ready for review May 11, 2025 21:21
@spwoodcock
Copy link
Member

I think this is good to go, as it shouldn't change the standard functionality of using the mini 4 pro 🀞

I might merge this soon @nrjadkry in order to add the Potensic Atom as a drone option =)
If you get a chance please let me know if this PR has any obvious issues

@spwoodcock spwoodcock added priority:high Should be addressed as a priority and removed priority:high Should be addressed as a priority labels May 13, 2025
@spwoodcock spwoodcock merged commit 40579d6 into develop Jun 21, 2025
2 checks passed
@spwoodcock spwoodcock deleted the feat/djj-air-3 branch June 21, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code dependency:drone-flightplan Requires updates in drone-flightplan enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for DJI Air 3
3 participants