Skip to content

test PR to replicate issue #1775 #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: development
Choose a base branch
from
Draft

Conversation

ajvs
Copy link

@ajvs ajvs commented May 20, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Example: #1775

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added frontend:management Related to the management frontend code tests Related to automated code tests labels May 20, 2025
@spwoodcock spwoodcock marked this pull request as ready for review May 20, 2025 10:51
@spwoodcock spwoodcock marked this pull request as draft May 20, 2025 10:52
@spwoodcock
Copy link
Member

All the tests are currently skipped, so you will need to enable them again I think πŸ˜„

Good news is the test runs and gets this far though! So if they fail when the tests are enabled, we can confirm its either:

  • Lack of access to the environment called 'test' to use the variables (from forked repos)
  • An issue with playwright or the tests (less likely)

I have a feeling we need a way to make the test environment in Github accessible from forked repos - low risk, as that environment contains no secrets

@spwoodcock
Copy link
Member

Running now! I disabled the approval requirement on workflows from new contributors πŸ‘

@github-actions github-actions bot added the contrib External contributions, or not related to core functionality label May 26, 2025
healthcheck:
test: timeout 5s bash -c ':> /dev/tcp/127.0.0.1/80' || exit 1
test: timeout 5s bash -c ':> /dev/tcp/127.0.0.1/7051' || exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was healthcheck issue you mentioned πŸ‘

Copy link
Author

@ajvs ajvs May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did resolve the healthcheck issue, @spwoodcock.
I enabled the tests to check if they will work, but unfortunately they still fail. maybe the tests don't match the code in this branch?
Anyway, not sure if this is still related to the forked repo issue we were originally looking into.

Copy link
Member

@spwoodcock spwoodcock May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah perhaps not πŸ˜…

We disabled the e2e tests a while ago, after the issue regarding forked repos was made, so it's hard to address this issue without first re-enabling the e2e tests and ensuring they work first - sorry!

(the reason the e2e tests were disabled is simply due to lack of capacity / time)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries. :)
I'll work on another issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib External contributions, or not related to core functionality frontend:management Related to the management frontend code tests Related to automated code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants