-
-
Notifications
You must be signed in to change notification settings - Fork 63
test PR to replicate issue #1775 #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
All the tests are currently skipped, so you will need to enable them again I think π Good news is the test runs and gets this far though! So if they fail when the tests are enabled, we can confirm its either:
I have a feeling we need a way to make the test environment in Github accessible from forked repos - low risk, as that environment contains no secrets |
Running now! I disabled the approval requirement on workflows from new contributors π |
for more information, see https://pre-commit.ci
healthcheck: | ||
test: timeout 5s bash -c ':> /dev/tcp/127.0.0.1/80' || exit 1 | ||
test: timeout 5s bash -c ':> /dev/tcp/127.0.0.1/7051' || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was healthcheck issue you mentioned π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did resolve the healthcheck issue, @spwoodcock.
I enabled the tests to check if they will work, but unfortunately they still fail. maybe the tests don't match the code in this branch?
Anyway, not sure if this is still related to the forked repo issue we were originally looking into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah perhaps not π
We disabled the e2e tests a while ago, after the issue regarding forked repos was made, so it's hard to address this issue without first re-enabling the e2e tests and ensuring they work first - sorry!
(the reason the e2e tests were disabled is simply due to lack of capacity / time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries. :)
I'll work on another issue for now.
What type of PR is this? (check all applicable)
Related Issue
Example: #1775
Describe this PR
A brief description of how this solves the issue.
Screenshots
Please provide screenshots of the change.
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?