-
-
Notifications
You must be signed in to change notification settings - Fork 281
Update Rapid to v2.3.1 from v2.2.5 #6202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
8ec6e54
to
58af0f4
Compare
|
58af0f4
to
a169d8d
Compare
a169d8d
to
1ecfc1c
Compare
@tsmock how can we go ahead on this PR ? |
1ecfc1c
to
a4d5c37
Compare
EDIT: It looks like I didn't wait long enough for the job to get picked up and looked at the older run. |
2417cdc
to
ecc6b22
Compare
Next steps here is testing on dev server. Prioritising this for next release @royallsilwallz @manjitapandey @varun2948 |
fc33983
to
90eea50
Compare
@manjitapandey : That should be fixed now. |
hey @tsmock, can you rebase to the latest develop branch and push? |
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
90eea50
to
25395a8
Compare
|
The version upgrade will be from v2.2.5 to v2.3.1 since rapid got accidently upgraded to v2.2.5 in this PR during yarn lock generation. |
From @manjitapandey on slack:
|
There are fairly minimal changes required for this to work.
About the only thing of note is Rapid requires node 18 or later. Setting the
NODE_OPTIONS=--openssl-legacy-provider
environment variable will work around the following issue (see #6053):This depends upon moving to node 18 (see #5908).
EDIT: We are now on node 18.