Implemented: Dxp pagination component(#322) #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Sourabh
changed the title
ymaheshwari1
requested changes
Jan 16, 2025
…c of the getDisplayedPageCounts function (hotwax#322)
…e count button size proeprty dynamic(hotwax#322)
ymaheshwari1
requested changes
Jan 16, 2025
…rrentPage, and directly invoked updateCurrentPage from the template(hotwax#322) - Renamed the emitter from 'updatePageCount' to 'updatePageIndex' and the function name from 'getDisplayedPageCounts' to 'getDisplayedPageIndexes'.
ymaheshwari1
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#322
Short Description and Why It's Useful
updatePageIndexevent with the updated page index to notify the parent component.Screenshots of Visual Changes before/after (If There Are Any)
Is the changes contains any breaking change?
If there are any breaking change include those in the release notes file
Contribution and Currently Important Rules Acceptance