Skip to content

Commit

Permalink
Merge pull request #672 from priyanshee1604/#666
Browse files Browse the repository at this point in the history
Fixed: Search functionality to ensure the search bar remains visible in the 'Closed' tab, even when no match is found.(#666)
  • Loading branch information
ravilodhi authored Feb 5, 2025
2 parents 6471fa5 + 6237e8b commit 18014b9
Showing 1 changed file with 13 additions and 14 deletions.
27 changes: 13 additions & 14 deletions src/views/Closed.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,23 @@
</ion-header>

<ion-content ref="contentRef" :scroll-events="true" @ionScroll="enableScrolling()" id="filter">
<div class="header searchbar">
<ion-searchbar v-model="query.queryString" @keyup.enter="updateQueryString('queryString', $event.target.value)" />
<ion-item lines="full">
<ion-icon slot="start" :icon="listOutline"/>
<ion-label>{{ translate("Counts closed") }}</ion-label>
<ion-label slot="end">{{ (closedCycleCountsTotal || closedCycleCountsTotal === 0) ? closedCycleCountsTotal : "-" }}</ion-label>
</ion-item>
<ion-item lines="full">
<ion-icon slot="start" :icon="thermometerOutline"/>
<ion-label>{{ translate("Average variance") }}</ion-label>
<ion-label slot="end">{{ getAverageVariance() }}</ion-label>
</ion-item>
</div>
<p v-if="!cycleCounts.length" class="empty-state">
{{ translate("No cycle counts found") }}
</p>
<template v-else>
<div class="header searchbar">
<ion-searchbar v-model="query.queryString" @keyup.enter="updateQueryString('queryString', $event.target.value)" />
<ion-item lines="full">
<ion-icon slot="start" :icon="listOutline"/>
<ion-label>{{ translate("Counts closed") }}</ion-label>
<ion-label slot="end">{{ (closedCycleCountsTotal || closedCycleCountsTotal === 0) ? closedCycleCountsTotal : "-" }}</ion-label>
</ion-item>
<ion-item lines="full">
<ion-icon slot="start" :icon="thermometerOutline"/>
<ion-label>{{ translate("Average variance") }}</ion-label>
<ion-label slot="end">{{ getAverageVariance() }}</ion-label>
</ion-item>
</div>

<div class="list-item" v-for="count in cycleCounts" :key="count.inventoryCountImportId" @click="router.push(`/closed/${count.inventoryCountImportId}`)">
<ion-item lines="none">
<ion-icon :icon="storefrontOutline" slot="start"></ion-icon>
Expand Down

0 comments on commit 18014b9

Please sign in to comment.