Skip to content

Potential fixes for 3 code quality findings#116

Merged
ajm19826 merged 3 commits intomainfrom
ai-findings-autofix/games.html
Apr 13, 2026
Merged

Potential fixes for 3 code quality findings#116
ajm19826 merged 3 commits intomainfrom
ai-findings-autofix/games.html

Conversation

@ajm19826
Copy link
Copy Markdown
Member

This PR applies 3/4 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.

ajm19826 and others added 3 commits April 13, 2026 17:01
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@ajm19826 ajm19826 requested a review from khalid-ameri April 13, 2026 21:01
@ajm19826 ajm19826 marked this pull request as ready for review April 13, 2026 21:01
@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2b5a6e9.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@ajm19826 ajm19826 merged commit 1af73be into main Apr 13, 2026
10 checks passed
@ajm19826 ajm19826 deleted the ai-findings-autofix/games.html branch April 13, 2026 21:02
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes legacy Firebase v8 scripts, updates an internal link to include the .html extension, and corrects a comment in the search script. Feedback was provided regarding potential ReferenceErrors caused by the removal of Firebase scripts and a suggestion to use relative paths for internal links to improve portability.

I am having trouble creating individual review comments. Click here to see my feedback.

games.html (5-6)

high

Removing the Firebase v8 scripts from the top of the while keeping the v9 compat scripts at the bottom (lines 203-204) may cause a ReferenceError if main.js or feedback.js depend on the global firebase object. These scripts are executed immediately, whereas the compat scripts are loaded much later in the document. Consider moving the v9 compat scripts to the top of the to ensure they are available for subsequent scripts.

  <script src="https://www.gstatic.com/firebasejs/9.6.1/firebase-app-compat.js"></script>
  <script src="https://www.gstatic.com/firebasejs/9.6.1/firebase-auth-compat.js"></script>

games.html (296)

medium

Using an absolute URL for internal links is discouraged as it makes the code less portable and is inconsistent with other relative links used in this file (e.g., line 312). Using a relative path is preferred for internal navigation.

        <a class="game-card" href="games/pattern-planet.html">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants