Potential fixes for 3 code quality findings#116
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
Code Review
This pull request removes legacy Firebase v8 scripts, updates an internal link to include the .html extension, and corrects a comment in the search script. Feedback was provided regarding potential ReferenceErrors caused by the removal of Firebase scripts and a suggestion to use relative paths for internal links to improve portability.
I am having trouble creating individual review comments. Click here to see my feedback.
games.html (5-6)
Removing the Firebase v8 scripts from the top of the while keeping the v9 compat scripts at the bottom (lines 203-204) may cause a ReferenceError if main.js or feedback.js depend on the global firebase object. These scripts are executed immediately, whereas the compat scripts are loaded much later in the document. Consider moving the v9 compat scripts to the top of the to ensure they are available for subsequent scripts.
<script src="https://www.gstatic.com/firebasejs/9.6.1/firebase-app-compat.js"></script>
<script src="https://www.gstatic.com/firebasejs/9.6.1/firebase-auth-compat.js"></script>
games.html (296)
Using an absolute URL for internal links is discouraged as it makes the code less portable and is inconsistent with other relative links used in this file (e.g., line 312). Using a relative path is preferred for internal navigation.
<a class="game-card" href="games/pattern-planet.html">
This PR applies 3/4 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.