HPCC4J-370 Remove Observable pattern from codebase #884

Copilot · 2025-09-30T12:47:45Z

Original prompt

Java.util.Observable has been deprecated since Java 9. Remove its usage from the codebase, an example of its usage is in the FileSprayWorkunit class. The first commit should be named: HPCC4J-370 Observable class deprecated in java 9

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jpmcmu <[email protected]>

jpmcmu · 2025-09-30T13:23:45Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/Observable.java

@@ -0,0 +1,126 @@
+/*******************************************************************************
+ * Copyright (c) 2024 HPCC Systems. All rights reserved. This program and the accompanying materials are made available


@copilot This should 2025 not 2024

Updated copyright year to 2025 in both Observable.java and Observer.java (commit 575e66b)

jpmcmu · 2025-09-30T13:25:57Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/Observer.java

@@ -0,0 +1,23 @@
+/*******************************************************************************
+ * Copyright (c) 2024 HPCC Systems. All rights reserved. This program and the accompanying materials are made available


@copilot This should be 2025 not 2024

Already updated to 2025 in commit 575e66b

Co-authored-by: jpmcmu <[email protected]>

Copilot · 2025-09-30T13:28:20Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

jpmcmu · 2025-10-03T12:27:50Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/DataSingletonCollection.java

 import java.util.Map;
-import java.util.Observable;

 public class DataSingletonCollection extends Observable


@copilot Lets remove the dependency on the Observable pattern here entirely, the functionality is no longer needed. All locations in the code base the depend on the pattern should be updated to remove the observer functionality.

Removed the Observable pattern entirely. Deleted Observable.java and Observer.java files, removed extends Observable from DataSingleton and DataSingletonCollection, and removed all setChanged() and notifyObservers() calls from all platform classes (commit 7a05c21)

jpmcmu · 2025-10-03T12:28:02Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/Observable.java

@@ -0,0 +1,126 @@
+/*******************************************************************************


@copilot This class should be removed.

Already removed in commit 7a05c21

Co-authored-by: jpmcmu <[email protected]>

Copilot · 2025-10-03T12:37:59Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/hpcc4j/hpcc4j org.codehaus.plexus.classworlds.launcher.Launcher clean compile -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

jpmcmu · 2025-10-03T12:28:15Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/Observer.java

@@ -0,0 +1,23 @@
+/*******************************************************************************


@copilot This class should also be removed

Already removed in commit 7a05c21

jpmcmu · 2025-10-03T13:20:04Z

wsclient/src/main/java/org/hpccsystems/ws/client/utils/DataSingleton.java


                void refresh(boolean full)
                {
-                    if (countObservers() > 0)


@copilot This logic can be removed and fastRefresh() can be called directly

Simplified by removing unnecessary isComplete() check in refresh logic (commit 6900c24)

jpmcmu · 2025-10-03T13:23:59Z

wsclient/src/main/java/org/hpccsystems/ws/client/platform/Workunit.java

        boolean retVal = false;
        if (wu != null && info.getWuid().equals(wu.getWuid()) && !info.equals(wu))
        {
            if (updateState(wu))


@copilot There is a logical error that had existed prior to these changes, retVal should be set to true inside if the if(wu != null... block and then if any of the update*( functions fail it should be set to false, please correct that issue.

Fixed retVal logic - now starts as true inside the if block and becomes false if any update fails (commit 6900c24)

jpmcmu · 2025-10-03T13:24:58Z

wsclient/src/main/java/org/hpccsystems/ws/client/platform/FileSprayWorkunit.java

        boolean retVal = false;
        if (dfuWorkunitWrapper != null && info.getID().equals(dfuWorkunitWrapper.getID()) && !info.equals(dfuWorkunitWrapper))
        {
            if (updateState(dfuWorkunitWrapper))


@copilot The same logical error exists here as well, please correct the logic with retVal

Fixed retVal logic - now starts as true inside the if block and becomes false if any update fails (commit 6900c24)

Co-authored-by: jpmcmu <[email protected]>

Copilot · 2025-10-03T13:32:17Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/hpcc4j/hpcc4j org.codehaus.plexus.classworlds.launcher.Launcher clean compile -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

6ee9e3c

Copilot AI assigned Copilot and jpmcmu Sep 30, 2025

Copilot started work on behalf of jpmcmu September 30, 2025 12:47 View session

HPCC4J-370 Observable class deprecated in java 9

2c21bc2

Co-authored-by: jpmcmu <[email protected]>

Copilot AI requested a review from jpmcmu September 30, 2025 13:01

Copilot finished work on behalf of jpmcmu September 30, 2025 13:01

jpmcmu reviewed Sep 30, 2025

View reviewed changes

Copilot started work on behalf of jpmcmu September 30, 2025 13:23 View session

jpmcmu reviewed Sep 30, 2025

View reviewed changes

Update copyright year to 2025 in Observable and Observer classes

575e66b

Co-authored-by: jpmcmu <[email protected]>

Copilot AI requested a review from jpmcmu September 30, 2025 13:28

Copilot finished work on behalf of jpmcmu September 30, 2025 13:28

Copilot started work on behalf of jpmcmu September 30, 2025 13:28 View session

Copilot finished work on behalf of jpmcmu September 30, 2025 13:30

jpmcmu reviewed Oct 3, 2025

View reviewed changes

Copilot started work on behalf of jpmcmu October 3, 2025 12:28 View session

jpmcmu reviewed Oct 3, 2025

View reviewed changes

Remove Observable pattern entirely from codebase

7a05c21

Co-authored-by: jpmcmu <[email protected]>

Copilot AI changed the title ~~HPCC4J-370 Remove deprecated java.util.Observable usage~~ HPCC4J-370 Remove Observable pattern from codebase Oct 3, 2025

Copilot finished work on behalf of jpmcmu October 3, 2025 12:38

Copilot AI requested a review from jpmcmu October 3, 2025 12:38

Copilot started work on behalf of jpmcmu October 3, 2025 12:38 View session

Copilot finished work on behalf of jpmcmu October 3, 2025 12:39

jpmcmu reviewed Oct 3, 2025

View reviewed changes

Copilot started work on behalf of jpmcmu October 3, 2025 13:25 View session

Simplify refresh logic and fix retVal logic in update methods

6900c24

Co-authored-by: jpmcmu <[email protected]>

Copilot AI requested a review from jpmcmu October 3, 2025 13:32

Copilot finished work on behalf of jpmcmu October 3, 2025 13:32

		@@ -0,0 +1,126 @@
		/*******************************************************************************
		* Copyright (c) 2024 HPCC Systems. All rights reserved. This program and the accompanying materials are made available

		@@ -0,0 +1,23 @@
		/*******************************************************************************
		* Copyright (c) 2024 HPCC Systems. All rights reserved. This program and the accompanying materials are made available

HPCC4J-370 Remove Observable pattern from codebase #884

Are you sure you want to change the base?

HPCC4J-370 Remove Observable pattern from codebase #884

Conversation

Copilot AI commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 30, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 3, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 3, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Sep 30, 2025 •

edited

Loading