Open
Conversation
github-actions
bot
force-pushed
the
phpstan-baseline
branch
3 times, most recently
from
dec57a5 to
1cae88e
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
3 times, most recently
from
e45c4a8 to
86b2e66
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
7 times, most recently
from
845c3a7 to
ad1e8f0
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
7 times, most recently
from
7a2ca39 to
2a64581
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
6 times, most recently
from
20ffc95 to
aee31e3
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
4 times, most recently
from
6a7c8e3 to
b839009
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
6 times, most recently
from
f499bbd to
faf15b3
Compare
github-actions
bot
force-pushed
the
phpstan-baseline
branch
from
faf15b3 to
6aff747
Compare
hregis
pushed a commit
that referenced
this pull request
Apr 11, 2026
…7439) * FIX: Issue Dolibarr#37425 filling of field amount_main_currency for foreign money accounts The parameter amount_main_currency (argument #13 of addline()) was previously filled even when the bank account was already using the company main currency. This caused the field amount_main_currency to be populated incorrectly for transactions that were not foreign currency operations. The logic has been updated so that amount_main_currency is only filled when the transaction involves a foreign currency account. For accounts already using the company main currency, the value is now left NULL as expected. This aligns the behavior with the intended usage of addline() and prevents incorrect data in bank transaction records. * FIX: Issue Dolibarr#37425 filling of field amount_main_currency for foreign money accounts transfer.php: PhanTypeMismatchArgument: Argument 4 ($amount) is price2num((-1 * (float)($amount[$n]))) of type string but \Account::addline() takes float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan Check warning on line R189 Check warning: transfer.php: PhanTypeMismatchArgument: Argument 13 ($amount_main_currency) is $amount_main_currency_from of type ?string but \Account::addline() takes ?float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan * declare dateo * declare of variables before action script --------- Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
hregis
pushed a commit
that referenced
this pull request
Apr 11, 2026
* FIX: Issue Dolibarr#37425 filling of field amount_main_currency for foreign money accounts The parameter amount_main_currency (argument #13 of addline()) was previously filled even when the bank account was already using the company main currency. This caused the field amount_main_currency to be populated incorrectly for transactions that were not foreign currency operations. The logic has been updated so that amount_main_currency is only filled when the transaction involves a foreign currency account. For accounts already using the company main currency, the value is now left NULL as expected. This aligns the behavior with the intended usage of addline() and prevents incorrect data in bank transaction records. (cherry picked from commit cdc3655) * FIX: Issue Dolibarr#37425 filling of field amount_main_currency for foreign money accounts transfer.php: PhanTypeMismatchArgument: Argument 4 ($amount) is price2num((-1 * (float)($amount[$n]))) of type string but \Account::addline() takes float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan Check warning on line R189 Check warning: transfer.php: PhanTypeMismatchArgument: Argument 13 ($amount_main_currency) is $amount_main_currency_from of type ?string but \Account::addline() takes ?float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan (cherry picked from commit b8f222c) * declare dateo (cherry picked from commit 1401f74) * declare of variables before action script (cherry picked from commit 2b07209)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is automatically created to cleanup our baseline.
Since the last refresh of the baseline we have fixed 19 ignored errors.
Keep it up all! 💪
There are only 8653 ignored errors left 😅