Skip to content

remove unnecessary tokio-stream dependency#38

Merged
hrxi merged 1 commit intohrxi:masterfrom
spencerpogo:remove-tokio-stream-dep
Jun 12, 2025
Merged

remove unnecessary tokio-stream dependency#38
hrxi merged 1 commit intohrxi:masterfrom
spencerpogo:remove-tokio-stream-dep

Conversation

@spencerpogo
Copy link
Copy Markdown
Contributor

replace with method that the trait implementation delegates to:

impl<T> Stream for ReceiverStream<T> {
    type Item = T;

    fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
        self.inner.poll_recv(cx)
    }
}

FYI, the version of tokio doesn't build on windows for me because it depends on an old version of ntapi that now fails to compile so should probably update that

replace with method that the trait implementation delegates to
@hrxi
Copy link
Copy Markdown
Owner

hrxi commented Jun 12, 2025

FYI, the version of tokio doesn't build on windows for me because it depends on an old version of ntapi that now fails to compile so should probably update that

Just run cargo update in your project. tracing-loki is not holding you back, it's depending on any version that's newer than 1.17, so you can use the latest version of tokio, 1.45.1.

Copy link
Copy Markdown
Owner

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hrxi hrxi merged commit 8d16034 into hrxi:master Jun 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants