Ember 3.11 (#281)

html-next · Aug 4, 2019 · 726fb85 · 726fb85
1 parent 09d879b
commit 726fb85
Show file tree

Hide file tree

Showing 9 changed files with 477 additions and 576 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   root: true,
   parserOptions: {
-    ecmaVersion: 2017,
+    ecmaVersion: 2018,
     sourceType: 'module'
   },
   plugins: [
@@ -43,8 +43,7 @@ module.exports = {
         'tests/dummy/app/**'
       ],
       parserOptions: {
-        sourceType: 'script',
-        ecmaVersion: 2015
+        sourceType: 'script'
       },
       env: {
         browser: false,

diff --git a/.travis.yml b/.travis.yml
@@ -57,6 +57,7 @@ jobs:
     - env: EMBER_TRY_SCENARIO=ember-lts-2.16
     - env: EMBER_TRY_SCENARIO=ember-lts-2.18
     - env: EMBER_TRY_SCENARIO=ember-lts-3.4
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.8
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary

diff --git a/addon/-private/data-view/utils/supports-passive.js b/addon/-private/data-view/utils/supports-passive.js
@@ -4,6 +4,7 @@ try {
   let opts = Object.defineProperty({}, 'passive', {
     get() {
       supportsPassive = true;
+      return supportsPassive;
     }
   });
 

diff --git a/addon/components/vertical-collection/component.js b/addon/components/vertical-collection/component.js
@@ -1,4 +1,3 @@
-/* global Array, Math */
 import { empty, readOnly } from '@ember/object/computed';
 
 import Component from '@ember/component';

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -2,192 +2,194 @@
 
 const getChannelURL = require('ember-source-channel-url');
 
-module.exports = function() {
-  return Promise.all([
-    getChannelURL('release'),
-    getChannelURL('beta'),
-    getChannelURL('canary')
-  ]).then((urls) => {
-    return {
-      useYarn: true,
-      scenarios: [
-        {
-          name: 'ember-1.12',
-          bower: {
-            dependencies: {
-              ember: '~1.12.0',
-              'ember-cli-shims': 'ember-cli/ember-cli-shims#0.0.3',
-              'ember-data': '~1.13.0'
-            },
-            resolutions: {
-              ember: '~1.12.0',
-              'ember-cli-shims': '0.0.3',
-              'ember-data': '~1.13.0'
-            }
+module.exports = async function() {
+  return {
+    useYarn: true,
+    scenarios: [
+      {
+        name: 'ember-1.12',
+        bower: {
+          dependencies: {
+            ember: '~1.12.0',
+            'ember-cli-shims': 'ember-cli/ember-cli-shims#0.0.3',
+            'ember-data': '~1.13.0'
           },
-          npm: {
-            devDependencies: {
-              'ember-cli-shims': null,
-              'ember-cli-fastboot': null,
-              'ember-data': '~1.13.0',
-              'ember-source': null
-            }
+          resolutions: {
+            ember: '~1.12.0',
+            'ember-cli-shims': '0.0.3',
+            'ember-data': '~1.13.0'
           }
         },
-        {
-          name: 'ember-1.13',
-          bower: {
-            dependencies: {
-              'ember': '~1.13.0',
-              'ember-cli-shims': '0.0.6',
-              'ember-data': '~1.13.0'
-            },
-            resolutions: {
-              'ember': '~1.13.0',
-              'ember-cli-shims': '0.0.6',
-              'ember-data': '~1.13.0'
-            }
-          },
-          npm: {
-            devDependencies: {
-              'ember-cli-shims': null,
-              'ember-cli-fastboot': null,
-              'ember-data': '~1.13.15',
-              'ember-source': null
-            }
+        npm: {
+          devDependencies: {
+            'ember-cli-shims': null,
+            'ember-cli-fastboot': null,
+            'ember-data': '~1.13.0',
+            'ember-source': null
           }
-        },
-        {
-          name: 'ember-lts-2.4',
-          bower: {
-            dependencies: {
-              'ember-cli-shims': '~0.1.0',
-              'ember': 'components/ember#lts-2-4'
-            },
-            resolutions: {
-              'ember-cli-shims': '0.1.0',
-              'ember': 'lts-2-4'
-            }
+        }
+      },
+      {
+        name: 'ember-1.13',
+        bower: {
+          dependencies: {
+            'ember': '~1.13.0',
+            'ember-cli-shims': '0.0.6',
+            'ember-data': '~1.13.0'
           },
-          npm: {
-            devDependencies: {
-              'ember-cli-shims': null,
-              'ember-cli-fastboot': null,
-              'ember-data': '~2.4.0',
-              'ember-source': null
-            }
+          resolutions: {
+            'ember': '~1.13.0',
+            'ember-cli-shims': '0.0.6',
+            'ember-data': '~1.13.0'
           }
         },
-        {
-          name: 'ember-lts-2.8',
-          bower: {
-            dependencies: {
-              'ember': 'components/ember#lts-2-8'
-            },
-            resolutions: {
-              'ember': 'lts-2-8'
-            }
-          },
-          npm: {
-            devDependencies: {
-              'ember-cli-shims': '^1.2.0',
-              'ember-data': '~2.8.0',
-              'ember-source': null
-            }
+        npm: {
+          devDependencies: {
+            'ember-cli-shims': null,
+            'ember-cli-fastboot': null,
+            'ember-data': '~1.13.15',
+            'ember-source': null
           }
-        },
-        {
-          name: 'ember-lts-2.12',
-          env: {
-            EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
+        }
+      },
+      {
+        name: 'ember-lts-2.4',
+        bower: {
+          dependencies: {
+            'ember-cli-shims': '~0.1.0',
+            'ember': 'components/ember#lts-2-4'
           },
-          npm: {
-            devDependencies: {
-              '@ember/jquery': '^0.5.1',
-              'ember-source': '~2.12.0'
-            }
+          resolutions: {
+            'ember-cli-shims': '0.1.0',
+            'ember': 'lts-2-4'
           }
         },
-        {
-          name: 'ember-lts-2.16',
-          env: {
-            EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
-          },
-          npm: {
-            devDependencies: {
-              '@ember/jquery': '^0.5.1',
-              'ember-source': '~2.16.0'
-            }
+        npm: {
+          devDependencies: {
+            'ember-cli-shims': null,
+            'ember-cli-fastboot': null,
+            'ember-data': '~2.4.0',
+            'ember-source': null
           }
-        },
-        {
-          name: 'ember-lts-2.18',
-          env: {
-            EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
+        }
+      },
+      {
+        name: 'ember-lts-2.8',
+        bower: {
+          dependencies: {
+            'ember': 'components/ember#lts-2-8'
           },
-          npm: {
-            devDependencies: {
-              '@ember/jquery': '^0.5.1',
-              'ember-source': '~2.18.0'
-            }
+          resolutions: {
+            'ember': 'lts-2-8'
           }
         },
-        {
-          name: 'ember-lts-3.4',
-          npm: {
-            devDependencies: {
-              'ember-source': '~3.4.0'
-            }
+        npm: {
+          devDependencies: {
+            'ember-cli-shims': '^1.2.0',
+            'ember-data': '~2.8.0',
+            'ember-source': null
           }
+        }
+      },
+      {
+        name: 'ember-lts-2.12',
+        env: {
+          EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
         },
-        {
-          name: 'ember-release',
-          npm: {
-            devDependencies: {
-              'ember-source': urls[0]
-            }
+        npm: {
+          devDependencies: {
+            '@ember/jquery': '^0.5.1',
+            'ember-source': '~2.12.0'
           }
+        }
+      },
+      {
+        name: 'ember-lts-2.16',
+        env: {
+          EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
         },
-        {
-          name: 'ember-beta',
-          npm: {
-            devDependencies: {
-              'ember-source': urls[1]
-            }
+        npm: {
+          devDependencies: {
+            '@ember/jquery': '^0.5.1',
+            'ember-source': '~2.16.0'
           }
+        }
+      },
+      {
+        name: 'ember-lts-2.18',
+        env: {
+          EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
         },
-        {
-          name: 'ember-canary',
-          npm: {
-            devDependencies: {
-              'ember-source': urls[2]
-            }
+        npm: {
+          devDependencies: {
+            '@ember/jquery': '^0.5.1',
+            'ember-source': '~2.18.0'
           }
-        },
-        // The default `.travis.yml` runs this scenario via `yarn test`,
-        // not via `ember try`. It's still included here so that running
-        // `ember try:each` manually or from a customized CI config will run it
-        // along with all the other scenarios.
-        {
-          name: 'ember-default',
-          npm: {
-            devDependencies: {}
+        }
+      },
+      {
+        name: 'ember-lts-3.4',
+        npm: {
+          devDependencies: {
+            'ember-source': '~3.4.0'
+          }
+        }
+      },
+      {
+        name: 'ember-lts-3.8',
+        npm: {
+          devDependencies: {
+            'ember-source': '~3.8.0'
+          }
+        }
+      },
+      {
+        name: 'ember-release',
+        npm: {
+          devDependencies: {
+            'ember-source': await getChannelURL('release')
+          }
+        }
+      },
+      {
+        name: 'ember-beta',
+        npm: {
+          devDependencies: {
+            'ember-source': await getChannelURL('beta')
+          }
+        }
+      },
+      {
+        name: 'ember-canary',
+        npm: {
+          devDependencies: {
+            'ember-source': await getChannelURL('canary')
           }
+        }
+      },
+      // The default `.travis.yml` runs this scenario via `yarn test`,
+      // not via `ember try`. It's still included here so that running
+      // `ember try:each` manually or from a customized CI config will run it
+      // along with all the other scenarios.
+      {
+        name: 'ember-default',
+        npm: {
+          devDependencies: {}
+        }
+      },
+      {
+        name: 'ember-default-with-jquery',
+        env: {
+          EMBER_OPTIONAL_FEATURES: JSON.stringify({
+            'jquery-integration': true
+          })
         },
-        {
-          name: 'ember-default-with-jquery',
-          env: {
-            EMBER_OPTIONAL_FEATURES: JSON.stringify({
-              'jquery-integration': true
-            })
-          },
-          npm: {
-            devDependencies: {
-              '@ember/jquery': '^0.5.1'
-            }
+        npm: {
+          devDependencies: {
+            '@ember/jquery': '^0.5.1'
           }
         }
-      ]
-    };
-  });
+      }
+    ]
+  };
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ try { @@
       let opts = Object.defineProperty({}, 'passive', {
         get() {
           supportsPassive = true;
+          return supportsPassive;
         }
       });
@@ Expand Down @@