Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TCP_NODELAY and TTL options. #15

Merged
merged 3 commits into from
May 25, 2021
Merged

Add TCP_NODELAY and TTL options. #15

merged 3 commits into from
May 25, 2021

Conversation

fiag
Copy link
Contributor

@fiag fiag commented May 19, 2021

refer to http-rs/tide#823. 😄

jbr
jbr approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@jbr jbr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks! updated below with further review

@jbr jbr self-requested a review May 22, 2021 23:30
jbr
jbr requested changes May 22, 2021
View reviewed changes
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other configuration is done through the TlsListenerBuilder, so the interface for this configuration should be done there as well (not on the TlsListener). However, the TlsListener should retain tcp_nodelay and tcp_ttl options as in this PR

jbr
jbr approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbr jbr merged commit cbfb61f into http-rs:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiag @jbr