Binary Graph Input Revision #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary graph + binary graph file.
…irected, Unweighted, Timestamped).
Collaborator
Author
|
I am aware we need the writing counterpart to this PR. However, I would prefer to finish this PR first and then make an additional one for writing graph data to a binary GDSB file. |
domischweisgut
approved these changes
Dec 16, 2024
Collaborator
domischweisgut
left a comment
domischweisgut
left a comment
There was a problem hiding this comment.
It is easy to see what the new code does. That's very nice! :)
Collaborator
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Definition: one of the issues with reading in edges of a GDSB binary file is that it is up to the user how to read in an edge. This may lead to unintended behavior (or bugs) if the order or the read type is incorrect.
Solution: instead of leaving it up to the user on how to read in an edge from a binary stream, we now offer convenience functions to do so.
Please note that by passing the edge type by reference we will not have to construct an edge in place which may reduce computational overhead of the users application, and makes it easy to overload the functions with the respective type.