Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-1147 Fix display of provenance table for datasets with large ancestor trees #3690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR fixes the display of provenance tables for datasets with more than 10 ancestors. Since there was no size specified on the relevant query, not all ancestor information was being loaded, which caused error tiles to show up instead for every ancestor ID that was listed in the entity's data and was not reflected in the follow-up query.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-1147

Testing

Manually tested

Screenshots/Video

image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant