Replace pathlib with cloudpathlib #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles an error caused by treating S3 URIs like a regular path. Instead, we can use cloudpathlib, which acts like Python's built-in pathlib but recognizes the URI formats of various cloud providers.
bsweger
commented
May 15, 2024
There was a problem hiding this comment.
this is auto-generated by PDM (which is slated for removal, but it's still here for now)
MyPy throws attr-defined errors on code that uses methods from cloudpathlib's AnyPath object (AnyPath will instantiate a cloud path instance or a pathlib.Path instance, depending on what is passed to it). There may be a clever workaround, but I'm not sure the juice is worth the squeeze.
matthewcornell
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles an error caused by treating S3 URIs like a regular path.
Instead, we can use cloudpathlib, which acts like Python's built-in pathlib but recognizes the URI formats of various cloud providers.