Feature/PLG auth us#1876
Closed
pascal-meunier wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
this PR got different code mixed in. Cancelling and trying again to create a clean PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: file permissions require a group for people in the US. Filling the iplocation table of the network database with a copy of the ip ranges applicable to the us is silly because that's a lot of rows to copy and it creates a management problem to keep the copy up to date. Instead, this plugin uses an SQL query with a join operation.
Three files created under core/plugins/user/us/:
- us.php — on login, queries the ipcountry table in the geo database using INET_ATON(). If countrySHORT == 'US', adds the user to location_us. Logs both the
match and non-match cases. On account deletion, removes the user from location_us (with is_object() guard).
- us.xml — extension manifest
- language/en-GB/en-GB.plg_user_us.sys.ini — admin UI label