Skip to content

Conversation

onursatici
Copy link
Contributor

No description provided.

elif pyarrow.types.is_large_string(arrow_type):
return "large_string"
elif pyarrow.types.is_string_view(arrow_type):
return "string_view"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pa.string_view exists, so in the complementing functionstring_to_arrow("string_view") will return pa.StringView correctly

@onursatici
Copy link
Contributor Author

@lhoestq who do you think would be the best to have a look at this? Any pointers would be appreciated, thanks!

@lhoestq
Copy link
Member

lhoestq commented Sep 4, 2025

Hi ! what's the rationale for supporting string view ? I'm afraid it can complexify the typing logic without much value

@onursatici
Copy link
Contributor Author

Hi @lhoestq ! I mainly want to be able to create features by using Features.from_arrow_schema(dataset_schema) on an arrow dataset with string view columns, currently there is no easy way to do this, and string_view is becoming an increasingly common data type for string columns in arrow. Thanks for having a look!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. It's indeed useful for some optimizations / power users

@lhoestq lhoestq merged commit 5e04865 into huggingface:main Sep 12, 2025
6 of 14 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants