Accept string[] as feature-extraction input #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
pcuenca and
ngxson
as code owners
julien-c
approved these changes
Feb 3, 2025
Wauplin
added a commit
that referenced
this pull request
Feb 5, 2025
Related to #1166 (and see #1178). In #1166, I've made possible to pass either a `string` or `string[]` as `feature-extraction` input. But since this schema is based on TEI via the `inference-tei-import` script, we also need to update it which this PR does. **Expectation:** exact same specs but this time we won't have a PR like https://github.com/huggingface/huggingface.js/pull/1178/files opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to huggingface/huggingface_hub#2824.
This PR makes it possible to send a
string[]instead ofstringasfeature-extractioninputs. This is already possible in practice in Inference API but not documented.In the past, I've pushed back on this change (see huggingface/huggingface_hub#1745 and huggingface/huggingface_hub#1746 (comment)) but I think it's fine to revisit it now. The main reason I mentioned was that
feature-extraction's server-side implementation was mostly a for-loop on the text input so acception astring[]would not really improve performances. That been said, there has been quite some improvements since then and especially thetext-embedding-inferenceframework.