Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] Format \t tabs to ' ' 4 spaces in snippets inputs #1302

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 20, 2025

Just an alignment with the rest of the snippets (and inputs snippets).

Suggested by @julien-c but at some point would be good to just run ruff/prettier on the generated snippets so that we don't have to handle this manually.

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also do the replace in the getSnippets function (plus that would allow the user to specify the indent per tab as an optional param)

.replace(/\t/g, " ".repeat(4));

@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 21, 2025

you could also do the replace in the getSnippets function (plus that would allow the user to specify the indent per tab as an optional param)

Yes indeed. I could also make these inputs normal objects and serialize them correctly downstream (as for some other inputs). But short term that was the quickest solution without touching the tooling again.

Will merge this PR "as is" now. CI failure doesn't seem related to my changes.

@Wauplin Wauplin merged commit e0de008 into main Mar 21, 2025
4 of 5 checks passed
@Wauplin Wauplin deleted the tabs-to-whitespace-in-inputs branch March 21, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants