Skip to content

Add fme to model libraries #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oliverwm1
Copy link

This is the library used for training and running Ai2 Climate Emulator: https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oliverwm1 , thanks opening this PR! Content looks good to me with a small suggestion on the naming. Also, for this PR to work you'll have to tag the models in https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4 with library_name: fme. I opened https://huggingface.co/allenai/ACE-climSST/discussions/2 as a demo PR. Other models should be tagged the same way. Please let me know once that's done and we should be good to merge!

Comment on lines +393 to +394
prettyLabel: "fme",
repoName: "fme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prettyLabel: "fme",
repoName: "fme",
prettyLabel: "Fuil Model Emulation",
repoName: "Fuil Model Emulation",

Only a suggestion, based on https://ai2-climate-emulator.readthedocs.io/en/latest/. It feels more explicit than "fme". I'm fine with either solution as long as we put the same value in both prettyLabel and repoName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants