Add fme to model libraries #1559
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverwm1
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
Wauplin
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Hi @oliverwm1 , thanks opening this PR! Content looks good to me with a small suggestion on the naming. Also, for this PR to work you'll have to tag the models in https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4 with library_name: fme. I opened https://huggingface.co/allenai/ACE-climSST/discussions/2 as a demo PR. Other models should be tagged the same way. Please let me know once that's done and we should be good to merge!
Comment on lines
+393
to
+394
| prettyLabel: "fme", | ||
| repoName: "fme", |
There was a problem hiding this comment.
Suggested change
| prettyLabel: "fme", | |
| repoName: "fme", | |
| prettyLabel: "Fuil Model Emulation", | |
| repoName: "Fuil Model Emulation", |
Only a suggestion, based on https://ai2-climate-emulator.readthedocs.io/en/latest/. It feels more explicit than "fme". I'm fine with either solution as long as we put the same value in both prettyLabel and repoName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the library used for training and running Ai2 Climate Emulator: https://huggingface.co/collections/allenai/ace-67327d822f0f0d8e0e5e6ca4