Fix: Handle nested config dict in add_mcp_server to prevent KeyError: 'command'
#3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mihirdeo16 , thanks for suggesting this fix! As explained in #3203 (comment), the change is intentional and we don't want to support the use case where |
|
Yep no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses issue #3203 by adding support for a nested config dictionary when calling
add_mcp_server.To fix the issue, added a simple fallback to unwrap the nested config. This allows both nested and flat parameter formats to work without breaking existing usage. Tested locally with agent.json of input to confirm that the function now works as expected without throwing an error. I noticed currently, there doesn't seem to be one for this path under tests.