Skip to content

liger-kernels: add device context manager#1029

Merged
vasqu merged 3 commits into
mainfrom
liger-device-context
Jul 20, 2026
Merged

liger-kernels: add device context manager#1029
vasqu merged 3 commits into
mainfrom
liger-device-context

Conversation

@vasqu

@vasqu vasqu commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

It's affecting models that use device map auto (under multi gpu setting) and use_kernels=True, e.g. RMS Norm gets corrupted. But this goes for any triton kernel launch so it is propogated to all of them

For more details, see linkedin/Liger-Kernel#1303

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Jul 15, 2026
@vasqu

vasqu commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-stage

@github-actions

Copy link
Copy Markdown

No kernels provided. Use /kernel-bot <build|security-and-build|build-and-stage|merge-and-upload> <kernel1> [kernel2 ...].

@vasqu

vasqu commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-stage liger-kernels

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage liger-kernels
Mode: build and stage
Target branch: pr-1029
PR head SHA: 83cd58309bce3df43a152e4227bd854a55c40423
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@vasqu

vasqu commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-stage liger-kernels

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage liger-kernels
Mode: build and stage
Target branch: pr-1029
PR head SHA: 9e9db35482a2cfaf3a5550681820114dcccc4c6f
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

sayakpaul
sayakpaul previously approved these changes Jul 17, 2026

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it applies to all kernels that don't have this fix as you also pointed out in Slack. But I guess we can treat on a case by case basis?

@vasqu

vasqu commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Let me hunt them all down as best as I can, I think it's low effort for big impact tbh so no need to delay on case by case imo

@vasqu
vasqu marked this pull request as ready for review July 17, 2026 15:50
@vasqu

vasqu commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Added it to all triton launches I could find

@vasqu
vasqu merged commit 0c5fb33 into main Jul 20, 2026
6 checks passed
@vasqu

vasqu commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot merge-and-upload liger-kernels

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot merge-and-upload liger-kernels
Mode: merge, build and upload
Target branch: ``
PR head SHA: 95f9074ecceaaddb2753cc7300a297d4eaed5a63
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Merge result: PR is already merged. Continuing with build/upload.

Dispatched (1):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants