feat: prefer reading the build toml from current ref#1036
Merged
Conversation
Collaborator
Author
|
re merging as the original PR was approved and this branch just corrects where the changes are merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-targets #982 at
main. That PR was merged intokernel-bot-refactor, which had already been squash-merged and closed via #983 three weeks earlier — so the change never reachedmain.The kernel bot checks out the default branch, so it read
build.tomlfrommainrather than from the PR. A kernel whosebuild.tomlis added or whosebackendschange in the PR got the wrong workflow set — a new cuda-only kernel would still dispatchbuild-mac.yaml.read_backendsnow takes an optionalrefand reads viagit show <ref>:<kernel>/build.toml. Empty ref keeps the working-tree read, so dry-run and local behavior are unchanged.pr-comment-build.yamlfetches the PR head at depth 1 so the blob is available.Cherry-picked onto current
main, which required reconciling with #1016:select_workflowsthere takesbackendsas a parameter soparse_kernel_argcan support inline overrides (relu[cuda,rocm]). Kept that design and threadedmetadata_refonly throughread_backends— applying the original version as-written would have bypassed the requested-backends filter. Tests rewritten fromunittestto pytest to matchmain.57 tests pass.