fix(ci): bump Node to 22 for Vite 8 (dist rebuild workflow + Space Dockerfile)#27
Merged
nicolas-rabault merged 1 commit intoJun 9, 2026
Conversation
…ckerfile) A Dependabot PR bumped the repo to Vite 8 (build(deps-dev): bump vite 5→8), which requires Node ^20.19.0 || >=22.12.0. Two build pipelines were still pinned to Node 18, so `npm run build` fails on both: - .github/workflows/build_frontend.yml — the "Rebuild frontend/dist" workflow. Its build failed silently, so the committed frontend/dist stopped being regenerated and the shipped bundle fell behind the merged source (e.g. the PR huggingface#21 calibration UI never reached dist). - frontend/Dockerfile — the image the Hugging Face Space builds. Its `npm run build` step fails, so the Space shows a build error. Bump both to Node 22. The rebuild workflow also triggers on changes to its own file, so merging this re-runs it and regenerates dist from the current source.
cn0303
force-pushed
the
fix/frontend-dist-stale-node-bump
branch
from
June 8, 2026 21:55
f9bb453 to
f2a0695
Compare
nicolas-rabault
self-requested a review
June 9, 2026 08:24
nicolas-rabault
approved these changes
Jun 9, 2026
nicolas-rabault
left a comment
Member
There was a problem hiding this comment.
Thank you,
You fix things faster than I catch the bugs 🤗.
Contributor
Author
|
Thanks a lot!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A Dependabot PR bumped the repo to Vite 8 (
build(deps-dev): bump vite 5→8),which requires Node
^20.19.0 || >=22.12.0. Two build pipelines were stillpinned to Node 18, so
npm run buildfails on both. This bumps both toNode 22.
The two breakages (same root cause)
1.
.github/workflows/build_frontend.yml— the "Rebuild frontend/dist"workflow. On Node 18 its build failed silently (a stale generated file, not a
red ❌), so the committed
frontend/diststopped being regenerated and theshipped bundle fell behind the merged source — e.g. the PR #21 calibration
UI never reached
dist, so a plainpip install/lelabrun still served theold UI.
2.
frontend/Dockerfile— the image the Hugging Face Space builds(
FROM node:18-alpine). Itsnpm run buildstep fails, so the Space currentlyshows a build error and the live demo is down.
build tool's Node requirement, but nothing bumped the
node-versionin CI orthe
node:18-alpinebase image, and the failures are easy to miss (a stalefile, and a Space build error on a separate runtime). It may be worth having
Dependabot also watch
actions/setup-node/ the Dockerfile base image so afuture build-tool bump can't silently desync these again.
Notes
this re-runs it on Node 22 and regenerates
frontend/distfrom the currentsource — no hand-built
distis committed here.the base-image tag only.