-
Notifications
You must be signed in to change notification settings - Fork 325
Update translation_literals.py #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Try again to provide the Romanian literals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Romanian translation literals to the translation system. Previously, the Romanian entry was incomplete and only contained the language identifier, causing runtime errors when Romanian translations were attempted.
- Adds comprehensive Romanian translations for all required literal fields
- Replaces the incomplete Romanian entry with proper translation values
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Language.ROMANIAN: TranslationLiterals( | ||
language=Language.ROMANIAN, | ||
question_word="întrebare", | ||
answer="răspuns", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are trailing spaces after the string values. Remove the trailing space after "răspuns".
answer="răspuns", | |
answer="răspuns", |
Copilot uses AI. Check for mistakes.
question_word="întrebare", | ||
answer="răspuns", | ||
confirmation_word="corect", | ||
yes="da", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the trailing space after "da".
yes="da", | |
yes="da", |
Copilot uses AI. Check for mistakes.
also="de asemenea", | ||
cause_word="pentru că", | ||
effect_word="prin urmare", | ||
or_word="sau", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the trailing space after "sau".
or_word="sau", | |
or_word="sau", |
Copilot uses AI. Check for mistakes.
cause_word="pentru că", | ||
effect_word="prin urmare", | ||
or_word="sau", | ||
and_word="și", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the trailing space after "și".
Copilot uses AI. Check for mistakes.
or_word="sau", | ||
and_word="și", | ||
true="adevărat", | ||
false="fals", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the trailing space after "fals".
Copilot uses AI. Check for mistakes.
and_word="și", | ||
true="adevărat", | ||
false="fals", | ||
neither="nici unul", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the trailing space after "nici unul".
neither="nici unul", | |
neither="nici unul", |
Copilot uses AI. Check for mistakes.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contrib ! You only need to apply the styling and we can merge :)
I applied the styling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Try again to provide the Romanian literals