Skip to content

Update translation_literals.py #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Conversation

dianaonutu
Copy link
Contributor

Try again to provide the Romanian literals

Try again to provide the Romanian literals
@NathanHB NathanHB requested a review from Copilot August 18, 2025 10:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Romanian translation literals to the translation system. Previously, the Romanian entry was incomplete and only contained the language identifier, causing runtime errors when Romanian translations were attempted.

  • Adds comprehensive Romanian translations for all required literal fields
  • Replaces the incomplete Romanian entry with proper translation values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Language.ROMANIAN: TranslationLiterals(
language=Language.ROMANIAN,
question_word="întrebare",
answer="răspuns",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are trailing spaces after the string values. Remove the trailing space after "răspuns".

Suggested change
answer="răspuns",
answer="răspuns",

Copilot uses AI. Check for mistakes.

question_word="întrebare",
answer="răspuns",
confirmation_word="corect",
yes="da",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing space after "da".

Suggested change
yes="da",
yes="da",

Copilot uses AI. Check for mistakes.

also="de asemenea",
cause_word="pentru că",
effect_word="prin urmare",
or_word="sau",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing space after "sau".

Suggested change
or_word="sau",
or_word="sau",

Copilot uses AI. Check for mistakes.

cause_word="pentru că",
effect_word="prin urmare",
or_word="sau",
and_word="și",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing space after "și".

Copilot uses AI. Check for mistakes.

or_word="sau",
and_word="și",
true="adevărat",
false="fals",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing space after "fals".

Copilot uses AI. Check for mistakes.

and_word="și",
true="adevărat",
false="fals",
neither="nici unul",
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing space after "nici unul".

Suggested change
neither="nici unul",
neither="nici unul",

Copilot uses AI. Check for mistakes.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib ! You only need to apply the styling and we can merge :)

@dianaonutu
Copy link
Contributor Author

I applied the styling

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@clefourrier clefourrier merged commit bab9f6d into huggingface:main Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants