-
Notifications
You must be signed in to change notification settings - Fork 328
Parametrizing the sampling evals from the CLI #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all old evals to the new format and figure out how to provide sane defaults
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…ey should have been
… a name update with parameter change
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 19, 2025
clefourrier
commented
Aug 20, 2025
NathanHB
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first round of review, few changes to do but overall so much better, great PR !
tests/reference_scores/SmolLM2-1.7B-Instruct-results-accelerate.json
Outdated
Show resolved
Hide resolved
NathanHB
reviewed
Aug 20, 2025
clefourrier
commented
Aug 20, 2025
Co-authored-by: Nathan Habib <[email protected]>
NathanHB
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things.
Metric
object creation.We go from
to
sample_level_fn
must derive from either aSampleLevelComputation
orPreparator
class. The former must implement acompute
method, the latter aprepare
one.corpus_level_fn
either is a function (np.mean and so on), or aCorpusLevelComputation
which must implement a.compute_corpus
class.All metrics with parametrizable sample_level_fn can now be parametrized at CLI call, example:
"lighteval|math_500@k=1|0|0"
(user can also use normalization function names if correctly defined in the normalization file). Corpus level parametrization is not supported but could probably be if we choose another symbol. This parametrization of Metrics.MyMetric relies on a trick in making the enum callable.The metric list has been simplified to remove duplicate metrics which were only different by some params
All tasks have therefore been changed to use the new metrics names.
The test suite has been updated