Skip to content

Conversation

clefourrier
Copy link
Member

See slack: https://huggingface.slack.com/archives/C07EPSS7ELX/p1755574013617059?thread_ts=1754563207.431879&cid=C07EPSS7ELX

cc @jsulz , if you want we can run the tests in a loop to see if they fail at any point (for the bugged version they would fail about half the time)

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@clefourrier
Copy link
Member Author

ran the test 2 times (I can rerun again, both successes)

@jsulz
Copy link

jsulz commented Aug 19, 2025

@clefourrier when I was testing this prior to the fix, I was able to get into a failed state ~20% of the time (for reasons beyond my understanding, this CI test was particularly adept at triggering the error).

If it's possible to run this in a loop for some finite number of times (in the range of 10ish iterations - I know that's quite a few 😬) that would likely be sufficient. 🙏

@clefourrier
Copy link
Member Author

We'll just keep the branch as is and update it with main regularly to force the test to go through

@jsulz
Copy link

jsulz commented Aug 21, 2025

Well, we're 6 runs in and it looks like all tests have succeeded (we've also had reports from other folks that this particular issue has abated).

I think you can merge this whenever you feel comfortable.

Thanks again for raising this (and providing a nice test bed for the issue). Appreciate it!

@NathanHB NathanHB merged commit f586400 into main Aug 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants