Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use SDPA in clip models #941

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Oct 11, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eaidova ! Opened huggingface/optimum#2066 to remove CLIPModelPatcher direclty in optimum (shouldn't be needed for onnx), would that works for you ?

@eaidova
Copy link
Collaborator Author

eaidova commented Oct 17, 2024

Thanks @eaidova ! Opened huggingface/optimum#2066 to remove CLIPModelPatcher direclty in optimum (shouldn't be needed for onnx), would that works for you ?

@echarlaix thanks, but are you sure that it is not need? as I understand @IlyasMoutawwakil met integration issue for onnx export that is why it was added

@echarlaix
Copy link
Collaborator

@echarlaix thanks, but are you sure that it is not need? as I understand @IlyasMoutawwakil met integration issue for onnx export that is why it was added

Actually might be needed for diffusers model, let's merge this PR for now and we can always revert changes if updated in optimum

@echarlaix echarlaix merged commit 981442f into huggingface:main Oct 17, 2024
15 of 17 checks passed
@eaidova eaidova deleted the ea/clip_enable_sdpa branch October 17, 2024 08:18
@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Oct 17, 2024

the specific onnx error was pytorch/pytorch#135615 and it was fixed in latest pytorch (not sure if stable or nightly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants