Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable awq related tests on XPU #377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Mar 17, 2025

What does this PR do?

As the title suggests, this PR makes awq tests that only run CUDA to run on XPU. Below is an evidence:

============================================================================= short test summary info =============================================================================
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[128-128]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[128-256]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[128-512]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[128-1024]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[256-128]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[256-256]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[256-512]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[256-1024]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[512-128]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[512-256]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[512-512]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[512-1024]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[1024-128]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[1024-256]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[1024-512]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_from_qbits_tensor[1024-1024]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_move[cpu]
PASSED test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_move[xpu]
SKIPPED [400] test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py:115: CUDA >= sm80 not available
=================================================================== 18 passed, 400 skipped, 1 warning in 1.33s ====================================================================

@faaany faaany requested a review from dacorvo as a code owner March 17, 2025 06:04
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull-request ! A few chnges are required to align with the existing test pattern.

@dacorvo dacorvo requested a review from SunMarc March 17, 2025 08:51
SunMarc
SunMarc previously approved these changes Mar 18, 2025
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks !

@SunMarc SunMarc requested a review from dacorvo March 18, 2025 11:30
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. You also need to use meaningful commits (at least a small sentence) otherwise they will be rejected by the CI. Your commit that contain the single word "update" is currently rejected. You can amend it and force-push (push -f) your branch.

@faaany
Copy link
Contributor Author

faaany commented Mar 20, 2025

done, thx!

@faaany
Copy link
Contributor Author

faaany commented Mar 21, 2025

I fixed the failed tests, but this test "test/tensor/weights/optimized/test_awq_weight_qbits_tensor.py::test_awq_weight_qbits_tensor_move[cuda]" still fails, also in main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants