Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid library_name guessing if it is known in parameters standartization #2179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eaidova
Copy link
Contributor

@eaidova eaidova commented Feb 4, 2025

What does this PR do?

in case if library_name detection has additional logic on optimum-integration path and not defined inside standard task manager approach to find library (e.g. open_clip integration), parameters standardization may fail as the library will not be detected properly.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@eaidova
Copy link
Contributor Author

eaidova commented Feb 4, 2025

@echarlaix @IlyasMoutawwakil could you please take a look?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova
Copy link
Contributor Author

eaidova commented Feb 5, 2025

@IlyasMoutawwakil @echarlaix could you please merge? Failed tests are not related (it looks like temporal connection to server issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants