Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update images type and docstring #1018

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Update images type and docstring #1018

merged 3 commits into from
Mar 19, 2025

Conversation

keetrap
Copy link
Contributor

@keetrap keetrap commented Mar 18, 2025

Fixes #1005

albertvillanova
albertvillanova reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

As you are using Image just for type hints, maybe better adding the import under TYPE_CHECKING.

Some additional comments below.

@keetrap
Copy link
Contributor Author

keetrap commented Mar 18, 2025

@albertvillanova Thanks for the review. Changes done.

albertvillanova
albertvillanova approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albertvillanova albertvillanova merged commit 9c4d0ed into huggingface:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Incorrect description of the images parameter in MultiStepAgent.run
2 participants
@keetrap @albertvillanova