Skip to content

feat: startup time: add cloned tokenzier fix, saves ~1-20s cold start time #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelfeil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: startup time: add cloned tokenzier fix, saves ~1-20s cold start time #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions core/src/tokenization.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,26 @@ impl Tokenization {
// Create channel
let (sender, receiver) = async_channel::bounded(workers * 4);

// Create workers
for _ in 0..workers {
let tokenizer_clone = tokenizer.clone();
let receiver_clone = receiver.clone();
let default_prompt_clone = default_prompt.clone();
let prompts_clone = prompts.clone();
// Spawn worker
std::thread::spawn(move || {
tokenizer_worker(
tokenizer_clone,
max_input_length,
position_offset,
default_prompt_clone,
prompts_clone,
receiver_clone,
)
});
}
// Spawn a background thread that creates all workers
// since tokenizer.clone() require 0.2s.
std::thread::spawn(move || {
for _ in 0..workers {
let tokenizer_clone = tokenizer.clone();
let receiver_clone = receiver.clone();
let default_prompt_clone = default_prompt.clone();
let prompts_clone = prompts.clone();
std::thread::spawn(move || {
tokenizer_worker(
tokenizer_clone,
max_input_length,
position_offset,
default_prompt_clone,
prompts_clone,
receiver_clone,
)
});
}
});

Self { sender }
}
Expand Down